Convert app_launch_index and page_index from int to StringOrdinal.

chrome/browser/resources/ntp4/new_tab.js

Index: chrome/browser/resources/ntp4/new_tab.js
diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js
index 35064fa9a8b168a78dc808f0a2e557bbc75ca246..cafa80a0316b163f9530010dcbd68d195e928d46 100644
--- a/chrome/browser/resources/ntp4/new_tab.js
+++ b/chrome/browser/resources/ntp4/new_tab.js
@@ -354,7 +354,7 @@ cr.define('ntp4', function() {
 
     // Sort by launch index
     apps.sort(function(a, b) {
-      return a.app_launch_index - b.app_launch_index;
+      return a.app_launch_index > b.app_launch_index;

[Dan Beam, 2011/11/12 02:28:30]

Hmmm, would it be better to

  return +a.app_launch_index - +b.app_launch_index;

to cast to decimal number or

  return window.parseInt(a.app_launch_index, 10) -
window.parseInt(b.app_launch_index);

possibly?

I guess this is OK as long as we never encounter something like

  "02" < "1" // true

I'm just trying to think of if this would ever result in strange bugs...

[csharp, 2011/11/14 16:22:28]

We don't want to do this because the app_launch_index values no longer have
integer values, they are represented as [a..z]*. Look at
chrome/common/string_ordinal.h for more information on exactly how they work.
Basically we've replaced the integers with StringOrdinals (which are
[b-z][a-z]*). They have the advantage that if we move an icon, we only need to
change the index of that icon to represent the new order, all the other values
can stay the same.

     });
 
     // An app to animate (in case it was just installed).