Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4109)

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.h
diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h
index 23ea41a5599b6a6de0f9cf308c1e351411f49510..f27f211bd7b6b6530714a53ef6f550591b4396c2 100644
--- a/chrome/browser/extensions/crx_installer.h
+++ b/chrome/browser/extensions/crx_installer.h
@@ -154,7 +154,7 @@ class CrxInstaller
install_cause_ = install_cause;
}
- void set_page_index(int page_index) {
+ void set_page_index(std::string page_index) {
page_index_ = page_index;
}
@@ -245,7 +245,7 @@ class CrxInstaller
scoped_refptr<const Extension> extension_;
// The index of the NTP apps page |extension_| will be shown on.
- int page_index_;
+ std::string page_index_;
// A parsed copy of the unmodified original manifest, before any
// transformations like localization have taken place.
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/extension_prefs.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698