Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/browser/extensions/crx_installer.h

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 } 147 }
148 148
149 extension_misc::CrxInstallCause install_cause() const { 149 extension_misc::CrxInstallCause install_cause() const {
150 return install_cause_; 150 return install_cause_;
151 } 151 }
152 152
153 void set_install_cause(extension_misc::CrxInstallCause install_cause) { 153 void set_install_cause(extension_misc::CrxInstallCause install_cause) {
154 install_cause_ = install_cause; 154 install_cause_ = install_cause;
155 } 155 }
156 156
157 void set_page_index(int page_index) { 157 void set_page_index(std::string page_index) {
158 page_index_ = page_index; 158 page_index_ = page_index;
159 } 159 }
160 160
161 private: 161 private:
162 friend class ExtensionUpdaterTest; 162 friend class ExtensionUpdaterTest;
163 163
164 virtual ~CrxInstaller(); 164 virtual ~CrxInstaller();
165 165
166 // Converts the source user script to an extension. 166 // Converts the source user script to an extension.
167 void ConvertUserScriptOnFileThread(); 167 void ConvertUserScriptOnFileThread();
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 // Whether to create an app shortcut after successful installation. This is 238 // Whether to create an app shortcut after successful installation. This is
239 // set based on the user's selection in the UI and can only ever be true for 239 // set based on the user's selection in the UI and can only ever be true for
240 // apps. 240 // apps.
241 bool create_app_shortcut_; 241 bool create_app_shortcut_;
242 242
243 // The extension we're installing. We own this and either pass it off to 243 // The extension we're installing. We own this and either pass it off to
244 // ExtensionService on success, or delete it on failure. 244 // ExtensionService on success, or delete it on failure.
245 scoped_refptr<const Extension> extension_; 245 scoped_refptr<const Extension> extension_;
246 246
247 // The index of the NTP apps page |extension_| will be shown on. 247 // The index of the NTP apps page |extension_| will be shown on.
248 int page_index_; 248 std::string page_index_;
249 249
250 // A parsed copy of the unmodified original manifest, before any 250 // A parsed copy of the unmodified original manifest, before any
251 // transformations like localization have taken place. 251 // transformations like localization have taken place.
252 scoped_ptr<base::DictionaryValue> original_manifest_; 252 scoped_ptr<base::DictionaryValue> original_manifest_;
253 253
254 // If non-empty, contains the current version of the extension we're 254 // If non-empty, contains the current version of the extension we're
255 // installing (for upgrades). 255 // installing (for upgrades).
256 std::string current_version_; 256 std::string current_version_;
257 257
258 // The icon we will display in the installation UI, if any. 258 // The icon we will display in the installation UI, if any.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 std::string original_mime_type_; 291 std::string original_mime_type_;
292 292
293 // What caused this install? Used only for histograms that report 293 // What caused this install? Used only for histograms that report
294 // on failure rates, broken down by the cause of the install. 294 // on failure rates, broken down by the cause of the install.
295 extension_misc::CrxInstallCause install_cause_; 295 extension_misc::CrxInstallCause install_cause_;
296 296
297 DISALLOW_COPY_AND_ASSIGN(CrxInstaller); 297 DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
298 }; 298 };
299 299
300 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 300 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/browser/extensions/extension_prefs.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698