Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8177005: Active smi-only optimizations for large array literals. (Closed)

Created:
9 years, 2 months ago by danno
Modified:
9 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Activate smi-only optimizations for large array literals. BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9553

Patch Set 1 #

Total comments: 6

Patch Set 2 : review feedback #

Patch Set 3 : review feedback #

Patch Set 4 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -183 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/arm/ic-arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/builtins.cc View 1 2 3 12 chunks +45 lines, -41 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +36 lines, -40 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 4 chunks +6 lines, -13 lines 0 comments Download
M src/runtime.cc View 1 5 chunks +22 lines, -17 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL. Guidance: - I removed most of the flag gates around smi-only array code, only ...
9 years, 2 months ago (2011-10-07 14:11:45 UTC) #1
Jakob Kummerow
LGTM http://codereview.chromium.org/8177005/diff/1/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/8177005/diff/1/src/builtins.cc#newcode413 src/builtins.cc:413: MaybeObject* maybe_writable_result = array->EnsureWritableFastElements(); nit: excess space after ...
9 years, 2 months ago (2011-10-07 17:58:13 UTC) #2
danno
9 years, 2 months ago (2011-10-10 11:26:33 UTC) #3
addressed feedback and landed

http://codereview.chromium.org/8177005/diff/1/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/8177005/diff/1/src/builtins.cc#newcode413
src/builtins.cc:413: MaybeObject* maybe_writable_result = 
array->EnsureWritableFastElements();
On 2011/10/07 17:58:13, Jakob wrote:
> nit: excess space after =

Done.

http://codereview.chromium.org/8177005/diff/1/src/builtins.cc#newcode414
src/builtins.cc:414: if (maybe_writable_result->IsFailure()) return
maybe_writable_result;
On 2011/10/07 17:58:13, Jakob wrote:
> You don't need this line (it's included in the next condition anyway).

Done.

http://codereview.chromium.org/8177005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/8177005/diff/1/src/objects-inl.h#newcode1658
src/objects-inl.h:1658: static int foo = 0;
On 2011/10/07 17:58:13, Jakob wrote:
> debugging leftover?

Done.

Powered by Google App Engine
This is Rietveld 408576698