Active smi-only optimizations for large array literals.

src/hydrogen.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3328 matching lines @@
 
     // Load the elements array before the first store.
     if (elements == NULL)  {
       elements = new(zone()) HLoadElements(literal);
       AddInstruction(elements);
     }
 
     HValue* key = AddInstruction(
         new(zone()) HConstant(Handle<Object>(Smi::FromInt(i)),
                               Representation::Integer32()));
-    if (FLAG_smi_only_arrays) {
-      HInstruction* elements_kind =
-          AddInstruction(new(zone()) HElementsKind(literal));
-      HBasicBlock* store_fast = graph()->CreateBasicBlock();
-      // Two empty blocks to satisfy edge split form.
-      HBasicBlock* store_fast_edgesplit1 = graph()->CreateBasicBlock();
-      HBasicBlock* store_fast_edgesplit2 = graph()->CreateBasicBlock();
-      HBasicBlock* store_generic = graph()->CreateBasicBlock();
-      HBasicBlock* check_smi_only_elements = graph()->CreateBasicBlock();
-      HBasicBlock* join = graph()->CreateBasicBlock();
+    HInstruction* elements_kind =
+        AddInstruction(new(zone()) HElementsKind(literal));
+    HBasicBlock* store_fast = graph()->CreateBasicBlock();
+    // Two empty blocks to satisfy edge split form.
+    HBasicBlock* store_fast_edgesplit1 = graph()->CreateBasicBlock();
+    HBasicBlock* store_fast_edgesplit2 = graph()->CreateBasicBlock();
+    HBasicBlock* store_generic = graph()->CreateBasicBlock();
+    HBasicBlock* check_smi_only_elements = graph()->CreateBasicBlock();
+    HBasicBlock* join = graph()->CreateBasicBlock();
 
-      HIsSmiAndBranch* smicheck = new(zone()) HIsSmiAndBranch(value);
-      smicheck->SetSuccessorAt(0, store_fast_edgesplit1);
-      smicheck->SetSuccessorAt(1, check_smi_only_elements);
-      current_block()->Finish(smicheck);
-      store_fast_edgesplit1->Finish(new(zone()) HGoto(store_fast));
+    HIsSmiAndBranch* smicheck = new(zone()) HIsSmiAndBranch(value);
+    smicheck->SetSuccessorAt(0, store_fast_edgesplit1);
+    smicheck->SetSuccessorAt(1, check_smi_only_elements);
+    current_block()->Finish(smicheck);
+    store_fast_edgesplit1->Finish(new(zone()) HGoto(store_fast));
 
-      set_current_block(check_smi_only_elements);
-      HCompareConstantEqAndBranch* smi_elements_check =
-          new(zone()) HCompareConstantEqAndBranch(elements_kind,
-                                                  FAST_SMI_ONLY_ELEMENTS,
-                                                  Token::EQ_STRICT);
-      smi_elements_check->SetSuccessorAt(0, store_generic);
-      smi_elements_check->SetSuccessorAt(1, store_fast_edgesplit2);
-      current_block()->Finish(smi_elements_check);
-      store_fast_edgesplit2->Finish(new(zone()) HGoto(store_fast));
+    set_current_block(check_smi_only_elements);
+    HCompareConstantEqAndBranch* smi_elements_check =
+        new(zone()) HCompareConstantEqAndBranch(elements_kind,
+                                                FAST_SMI_ONLY_ELEMENTS,
+                                                Token::EQ_STRICT);
+    smi_elements_check->SetSuccessorAt(0, store_generic);
+    smi_elements_check->SetSuccessorAt(1, store_fast_edgesplit2);
+    current_block()->Finish(smi_elements_check);
+    store_fast_edgesplit2->Finish(new(zone()) HGoto(store_fast));
 
-      set_current_block(store_fast);
-      AddInstruction(new(zone()) HStoreKeyedFastElement(elements, key, value));
-      store_fast->Goto(join);
+    set_current_block(store_fast);
+    AddInstruction(new(zone()) HStoreKeyedFastElement(elements, key, value));
+    store_fast->Goto(join);
 
-      set_current_block(store_generic);
-      AddInstruction(BuildStoreKeyedGeneric(literal, key, value));
-      store_generic->Goto(join);
+    set_current_block(store_generic);
+    AddInstruction(BuildStoreKeyedGeneric(literal, key, value));
+    store_generic->Goto(join);
 
-      join->SetJoinId(expr->id());
-      set_current_block(join);
-    } else {
-      AddInstruction(new(zone()) HStoreKeyedFastElement(elements, key, value));
-    }
+    join->SetJoinId(expr->id());
+    set_current_block(join);
 
     AddSimulate(expr->GetIdForElement(i));
   }
   return ast_context()->ReturnValue(Pop());
 }
 
 
 // Sets the lookup result and returns true if the store can be inlined.
 static bool ComputeStoredField(Handle<Map> type,
                                Handle<String> name,
@@ skipping 3543 matching lines @@
     }
   }
 
 #ifdef DEBUG
   if (graph_ != NULL) graph_->Verify(false);  // No full verify.
   if (allocator_ != NULL) allocator_->Verify();
 #endif
 }
 
 } }  // namespace v8::internal