Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 8176009: Merge 102569 - Fix in-use updates for Chrome Frame. (Closed)

Created:
9 years, 2 months ago by grt (UTC plus 2)
Modified:
9 years, 2 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 102569 - Fix in-use updates for Chrome Frame. On in-use updates, make a copy of the old chrome launcher's IE low rights elevation policy prior to registering the new npchrome_frame.dll so that running instances of IE can still launch Chrome. In so doing, I also removed elevation policy addition/removal code from the installer so that npchrome_frame.dll's {un,}registration code is the one and only place where this is done. BUG=95810 TEST=Install a previous version of GCF, run IE and visit some page that activates GCF, update to a version of GCF containing this fix, then try to visit another page that will activate GCF. If all goes well, you won't see an IE security prompt. Review URL: http://codereview.chromium.org/7976045 TBR=grt@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -255 lines) Patch
M chrome/installer/setup/install.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 3 chunks +68 lines, -50 lines 0 comments Download
M chrome/installer/setup/install_worker_unittest.cc View 8 chunks +84 lines, -124 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 6 chunks +45 lines, -28 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/installer/util/copy_reg_key_work_item.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/installer/util/copy_reg_key_work_item.cc View 3 chunks +28 lines, -13 lines 0 comments Download
M chrome/installer/util/copy_reg_key_work_item_unittest.cc View 6 chunks +44 lines, -5 lines 0 comments Download
M chrome/installer/util/work_item.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/work_item.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/installer/util/work_item_list.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/work_item_list.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_activex.rgs View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_frame_elevation.rgs View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_tab.cc View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
grt (UTC plus 2)
9 years, 2 months ago (2011-10-06 19:23:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698