Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome_frame/chrome_tab.cc

Issue 8176009: Merge 102569 - Fix in-use updates for Chrome Frame. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/835/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/chrome_frame_elevation.rgs ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_tab.cc
===================================================================
--- chrome_frame/chrome_tab.cc (revision 104338)
+++ chrome_frame/chrome_tab.cc (working copy)
@@ -8,6 +8,7 @@
#include "chrome_tab.h" // NOLINT
#include <atlsecurity.h>
+#include <objbase.h>
#include "base/at_exit.h"
#include "base/command_line.h"
@@ -181,6 +182,13 @@
DCHECK(SUCCEEDED(hr));
}
+ if (SUCCEEDED(hr)) {
+ // Add the Chrome Frame CLSID.
+ wchar_t cf_clsid[64];
+ StringFromGUID2(CLSID_ChromeFrame, &cf_clsid[0], arraysize(cf_clsid));
+ hr = registrar->AddReplacement(L"CHROME_FRAME_CLSID", &cf_clsid[0]);
+ }
+
return hr;
}
@@ -518,11 +526,9 @@
hr = ChromeFrameActivex::UpdateRegistry(reg);
}
- // Register the elevation policy. We do this only for developer convenience
- // as the installer is really responsible for doing this.
- // Because of that, we do not unregister this policy and just leave that up
- // to the installer.
- if (hr == S_OK && (flags & (ACTIVEDOC | ACTIVEX)) && reg) {
+ // Register the elevation policy. This must succeed for Chrome Frame to
+ // be able launch Chrome when running in low-integrity IE.
+ if (hr == S_OK && (flags & (ACTIVEDOC | ACTIVEX))) {
_AtlModule.UpdateRegistryFromResourceS(IDR_CHROMEFRAME_ELEVATION, reg);
RefreshElevationPolicy();
}
« no previous file with comments | « chrome_frame/chrome_frame_elevation.rgs ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698