Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3900)

Unified Diff: chrome/browser/ui/webui/options/extension_settings_handler.h

Issue 8176001: Warn user in case extension delays network traffic too much. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed Glen's comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/options/extension_settings_handler.h b/chrome/browser/ui/webui/options/extension_settings_handler.h
index d326a1d0bc43b6b3263615b49c53b0a35efda2bb..f0b267aec73234d2e0d4c38f4cc21f7c7a99255e 100644
--- a/chrome/browser/ui/webui/options/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/options/extension_settings_handler.h
@@ -10,6 +10,7 @@
#include <vector>
#include "chrome/browser/extensions/extension_install_ui.h"
+#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
#include "chrome/browser/ui/shell_dialogs.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
@@ -20,7 +21,6 @@
#include "googleurl/src/gurl.h"
class Extension;
-class ExtensionService;
class FilePath;
class PrefService;
class RenderProcessHost;
@@ -62,6 +62,7 @@ class ExtensionSettingsHandler : public OptionsPageUIHandler,
ExtensionService* service,
const Extension* extension,
const std::vector<ExtensionPage>& pages,
+ const ExtensionService::ExtensionWarningsType& warnings,
bool enabled,
bool terminated);
@@ -163,6 +164,9 @@ class ExtensionSettingsHandler : public OptionsPageUIHandler,
// needed.
ExtensionUninstallDialog* GetExtensionUninstallDialog();
+ // Returns a localized string for |warning|.
+ static string16 GetLocalizedWarning(const ExtensionServiceWarning& warning);
+
// Our model. Outlives us since it's owned by our containing profile.
ExtensionService* extension_service_;

Powered by Google App Engine
This is Rietveld 408576698