Warn user in case extension delays network traffic too much.

chrome/browser/ui/webui/options/extension_settings_handler.h

Index: chrome/browser/ui/webui/options/extension_settings_handler.h
diff --git a/chrome/browser/ui/webui/options/extension_settings_handler.h b/chrome/browser/ui/webui/options/extension_settings_handler.h
index d326a1d0bc43b6b3263615b49c53b0a35efda2bb..e5619c5e446c66e13c745e267f6fa2998401b3f7 100644
--- a/chrome/browser/ui/webui/options/extension_settings_handler.h
+++ b/chrome/browser/ui/webui/options/extension_settings_handler.h
@@ -11,6 +11,7 @@
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
+#include "chrome/browser/extensions/extension_warning_set.h"
 #include "chrome/browser/ui/shell_dialogs.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 #include "chrome/browser/ui/webui/chrome_web_ui.h"
@@ -57,11 +58,12 @@ class ExtensionSettingsHandler : public OptionsPageUIHandler,
   static void RegisterUserPrefs(PrefService* prefs);
 
   // Extension Detail JSON Struct for page. (static for ease of testing).
-  // Note: service can be NULL in unit tests.
+  // Note: |service| and |warnings| can be NULL in unit tests.
   static base::DictionaryValue* CreateExtensionDetailValue(
       ExtensionService* service,
       const Extension* extension,
       const std::vector<ExtensionPage>& pages,
+      const ExtensionWarningSet* warnings,
       bool enabled,
       bool terminated);
 
@@ -163,6 +165,10 @@ class ExtensionSettingsHandler : public OptionsPageUIHandler,
   // needed.
   ExtensionUninstallDialog* GetExtensionUninstallDialog();
 
+  // Returns a localized string for |warning_type|.
+  static string16 GetLocalizedWarning(
+      ExtensionWarning::WarningType warning_type);

[Finnur, 2011/10/10 09:59:24]

nit: static function should be at the top of the private section.

However, this feels like the wrong place for this function. Shouldn't it be in
the ExtensionWarning class, or there about?

[battre, 2011/10/10 13:16:36]

I have moved the function up. I did not move it into ExtensionWarning class. How
strongly do you feel about this? My opinion would be that localization should
not be in the core of an Extension class but rather part of the UI. The switch
statement in GetLocalizedWarning is written in such a way that adding a new enum
value triggers a compile failure if you don't extend GetLocalizedWarning.

[Finnur, 2011/10/10 15:06:56]

I don't feel strongly about it but if someone adds another UI class that also
uses the ExtensionWarning, they'd probably look in the ExtensionWarning class
for such a translate function, rather than here. If they don't find it, they
might duplicate the method and if they do find it in this class they would
probably be more likely to move it to the ExtensionWarning class (so they can
share it) rather than store it in some other common file they have access
to/need to create.

If the translate function were to have potentially different outcome based on
which UI class it was used in, then it would look a bit different.

But, maybe it is just me. 

On 2011/10/10 13:16:36, battre wrote:

[battre, 2011/10/10 15:55:57]

Convinced. Done.

+
   // Our model.  Outlives us since it's owned by our containing profile.
   ExtensionService* extension_service_;