Warn user in case extension delays network traffic too much.

chrome/browser/ui/webui/options/extension_settings_handler.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
+#include "chrome/browser/extensions/extension_warning_set.h"
 #include "chrome/browser/ui/shell_dialogs.h"
 #include "chrome/browser/ui/webui/options/options_ui.h"
 #include "chrome/browser/ui/webui/chrome_web_ui.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "googleurl/src/gurl.h"
 
 class Extension;
 class ExtensionService;
@@ skipping 26 matching lines @@
 class ExtensionSettingsHandler : public OptionsPageUIHandler,
                                  public SelectFileDialog::Listener,
                                  public ExtensionUninstallDialog::Delegate {
  public:
   ExtensionSettingsHandler();
   virtual ~ExtensionSettingsHandler();
 
   static void RegisterUserPrefs(PrefService* prefs);
 
   // Extension Detail JSON Struct for page. (static for ease of testing).
-  // Note: service can be NULL in unit tests.
+  // Note: |service| and |warnings| can be NULL in unit tests.
   static base::DictionaryValue* CreateExtensionDetailValue(
       ExtensionService* service,
       const Extension* extension,
       const std::vector<ExtensionPage>& pages,
+      const ExtensionWarningSet* warnings,
       bool enabled,
       bool terminated);
 
   // ContentScript JSON Struct for page. (static for ease of testing).
   static base::DictionaryValue* CreateContentScriptDetailValue(
       const UserScript& script,
       const FilePath& extension_path);
 
   // Callback for "requestExtensionsData" message.
   void HandleRequestExtensionsData(const base::ListValue* args);
@@ skipping 81 matching lines @@
       const Extension* extension);
   void GetActivePagesForExtensionProcess(
       RenderProcessHost* process,
       const Extension* extension,
       std::vector<ExtensionPage> *result);
 
   // Returns the ExtensionUninstallDialog object for this class, creating it if
   // needed.
   ExtensionUninstallDialog* GetExtensionUninstallDialog();
 
+  // Returns a localized string for |warning_type|.
+  static string16 GetLocalizedWarning(
+      ExtensionWarning::WarningType warning_type);

[Finnur, 2011/10/10 09:59:24]

nit: static function should be at the top of the private section.

However, this feels like the wrong place for this function. Shouldn't it be in
the ExtensionWarning class, or there about?

[battre, 2011/10/10 13:16:36]

I have moved the function up. I did not move it into ExtensionWarning class. How
strongly do you feel about this? My opinion would be that localization should
not be in the core of an Extension class but rather part of the UI. The switch
statement in GetLocalizedWarning is written in such a way that adding a new enum
value triggers a compile failure if you don't extend GetLocalizedWarning.

[Finnur, 2011/10/10 15:06:56]

I don't feel strongly about it but if someone adds another UI class that also
uses the ExtensionWarning, they'd probably look in the ExtensionWarning class
for such a translate function, rather than here. If they don't find it, they
might duplicate the method and if they do find it in this class they would
probably be more likely to move it to the ExtensionWarning class (so they can
share it) rather than store it in some other common file they have access
to/need to create.

If the translate function were to have potentially different outcome based on
which UI class it was used in, then it would look a bit different.

But, maybe it is just me. 

On 2011/10/10 13:16:36, battre wrote:

[battre, 2011/10/10 15:55:57]

Convinced. Done.

+
   // Our model.  Outlives us since it's owned by our containing profile.
   ExtensionService* extension_service_;
 
   // Used to pick the directory when loading an extension.
   scoped_refptr<SelectFileDialog> load_extension_dialog_;
 
   // Used to show confirmation UI for uninstalling extensions in incognito mode.
   scoped_ptr<ExtensionUninstallDialog> extension_uninstall_dialog_;
 
   // The id of the extension we are prompting the user about.
@@ skipping 14 matching lines @@
   // We want to register for notifications only after we've responded at least
   // once to the page, otherwise we'd be calling javacsript functions on objects
   // that don't exist yet when notifications come in. This variable makes sure
   // we do so only once.
   bool registered_for_notifications_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_OPTIONS_EXTENSION_SETTINGS_HANDLER_H_