Stop modifiying requirements out of thread and generate it instead.

Stop modifiying requirements out of thread and generate it instead.

This fixes GClientSmokeBoth.testMultiSolutionsJobs flakiness by having
consistent ordering.

Now no out of thread modification is ever done, which result in much saner code.

R=dpranke@chromium.org
BUG=60725
TEST=tested manually with gclient sync --jobs 100 on chrome and with
gclient_smotetest.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104920

[Dirk Pranke, 2011-10-06 21:45:26]

lgtm

[M-A Ruel, 2011-10-07 16:59:50]

Since it now uses strict sorting for the dependencies, I had to update a test
expectation.

[commit-bot: I haz the power, 2011-10-11 00:45:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8174014/4001

[commit-bot: I haz the power, 2011-10-11 00:52:20]

Presubmit check for 8174014-4001 failed and returned exit status 1.

Running presubmit commit checks ...
Syncing rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/gclient_smoketest.py failed!
Command tests/gclient_smoketest.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
.......F................................
======================================================================
FAIL: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1066, in testMultiSolutionsJobs
    untangle=True)
  File "tests/gclient_smoketest.py", line 77, in parseGclient
    return self.checkBlock(stdout, items)
  File "tests/gclient_smoketest.py", line 137, in checkBlock
    self.checkString(results[i][0][2], path, (i, results[i][0][2], path))
  File "/mnt/data/b/commit-queue/workdir/tools/depot_tools/tests/fake_repos.py",
line 682, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: (3,
'/tmp/trialBQ1LkY/__main__.GClientSmokeBoth.testMultiSolutionsJobs',
'/tmp/trialBQ1LkY/__main__.GClientSmokeBoth.testMultiSolutionsJobs/src/file/other')

----------------------------------------------------------------------
Ran 40 tests in 173.453s

FAILED (failures=1)


Presubmit checks took 380.6s to calculate.

[M-A Ruel, 2011-10-11 02:29:35]

Small update to make the test non-flaky. Will commit tomorrow morning.

http://codereview.chromium.org/8174014/diff/9001/tests/gclient_smoketest.py
File tests/gclient_smoketest.py (right):

http://codereview.chromium.org/8174014/diff/9001/tests/gclient_smoketest.py#n...
tests/gclient_smoketest.py:1069: self.assertEquals(12, len(results))
This verifies that all 12 steps went on and the tree is tested right after
anyway.

[commit-bot: I haz the power, 2011-10-11 18:09:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/8174014/9001

[commit-bot: I haz the power, 2011-10-11 18:18:21]

Change committed as 104920