Stop modifiying requirements out of thread and generate it instead.

gclient_utils.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import errno
 import logging
 import os
 import Queue
@@ skipping 461 matching lines @@
         raise
       return method(self, *args, **kwargs)
     finally:
       self.lock.release()
   return inner
 
 
 class WorkItem(object):
   """One work item."""
   def __init__(self, name):
-    # A list of string, each being a WorkItem name.
-    self._requirements = set()
     # A unique string representing this work item.
     self._name = name
     self.lock = threading.RLock()
 
-  @lockedmethod
   def run(self, work_queue):
     """work_queue is passed as keyword argument so it should be
     the last parameters of the function when you override it."""
     pass
 
   @property
   def name(self):
     return self._name
 
-  @property
-  @lockedmethod
-  def requirements(self):
-    return tuple(self._requirements)
-
-  @lockedmethod
-  def add_requirement(self, new):
-    self._requirements.add(new)
-
 
 class ExecutionQueue(object):
   """Runs a set of WorkItem that have interdependencies and were WorkItem are
   added as they are processed.
 
   In gclient's case, Dependencies sometime needs to be run out of order due to
   From() keyword. This class manages that all the required dependencies are run
   before running each one.
 
   Methods of this class are thread safe.
@@ skipping 153 matching lines @@
         logging.info('Caught exception in thread %s' % self.item.name)
         logging.info(str(sys.exc_info()))
         work_queue.exceptions.put(sys.exc_info())
       logging.info('_Worker.run(%s) done' % self.item.name)
 
       work_queue.ready_cond.acquire()
       try:
         work_queue.ready_cond.notifyAll()
       finally:
         work_queue.ready_cond.release()