Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Issue 8173016: Patch up excessive margins until we can get the real fix plumbed through. (Closed)

Created:
9 years, 2 months ago by vandebo (ex-Chrome)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Patch up excessive margins until we can get the real fix plumbed through. BUG=92000 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104442

Patch Set 1 #

Patch Set 2 : Fix headers and footers #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M chrome/renderer/print_web_view_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 7 chunks +30 lines, -11 lines 0 comments Download
M printing/print_job_constants.cc View 1 1 chunk +3 lines, -3 lines 2 comments Download
M printing/print_settings.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vandebo (ex-Chrome)
I'm still waiting on my Mac and Win compiles to finish so I can verify ...
9 years, 2 months ago (2011-10-06 23:36:20 UTC) #1
Lei Zhang
LGTM with nit below http://codereview.chromium.org/8173016/diff/2001/printing/print_job_constants.cc File printing/print_job_constants.cc (right): http://codereview.chromium.org/8173016/diff/2001/printing/print_job_constants.cc#newcode73 printing/print_job_constants.cc:73: const float kSettingHeaderFooterInterstice = 14.2f; ...
9 years, 2 months ago (2011-10-07 00:22:10 UTC) #2
vandebo (ex-Chrome)
http://codereview.chromium.org/8173016/diff/2001/printing/print_job_constants.cc File printing/print_job_constants.cc (right): http://codereview.chromium.org/8173016/diff/2001/printing/print_job_constants.cc#newcode73 printing/print_job_constants.cc:73: const float kSettingHeaderFooterInterstice = 14.2f; On 2011/10/07 00:22:10, Lei ...
9 years, 2 months ago (2011-10-07 00:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/8173016/2001
9 years, 2 months ago (2011-10-07 01:59:55 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 03:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/8173016/2001
9 years, 2 months ago (2011-10-07 03:47:09 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 04:49:18 UTC) #7
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 104437, job name
was 8173016-2001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

Powered by Google App Engine
This is Rietveld 408576698