printing/print_job_constants.cc - Issue 8173016: Patch up excessive margins until we can get the real fix plumbed through.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/print_job_constants.cc

Issue 8173016: Patch up excessive margins until we can get the real fix plumbed through. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix headers and footers Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/print_job_constants.cc

diff --git a/printing/print_job_constants.cc b/printing/print_job_constants.cc

index fa99f25f240ee9ea3cefa890e3c831fd87eb9a0c..3efb488044e9a9b1334085f88401a059ab2aa7ba 100644

--- a/printing/print_job_constants.cc

+++ b/printing/print_job_constants.cc

@@ -68,9 +68,9 @@ const int kSettingHeaderFooterFontSize = 8;

// Number of horizontal regions for headers and footers.

const float kSettingHeaderFooterHorizontalRegions = 3;

-// Interstice or gap between different header footer components.

-// Hardcoded to 0.25cm = 1/10" = 7.2points.

-const float kSettingHeaderFooterInterstice = 7.2f;

+// Interstice or gap between different header footer components. Hardcoded to

+// about 0.5cm, match the value in PrintSettings::SetPrinterPrintableArea.

+const float kSettingHeaderFooterInterstice = 14.2f;

Lei Zhang 2011/10/07 00:22:10 Shouldn't this be 14.4?

vandebo (ex-Chrome) 2011/10/07 00:29:50 Nope: http://www.google.com/search?q=.5cm+in+point

// Key that specifies the date of the page that will be printed in the headers

// and footers.

« no previous file with comments | « chrome/renderer/print_web_view_helper.cc ('k') | printing/print_settings.cc » ('j') | no next file with comments »