Simple clipboard support for aura

Simple clipboard support for aura

BUG=99128
TEST=more views_unittests tests pass on linux/aura

This include fixes from http://codereview.chromium.org/8150001

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104448

[sadrul, 2011-10-06 19:53:59]

LGTM

http://codereview.chromium.org/8165016/diff/2012/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_aura.cc (right):

http://codereview.chromium.org/8165016/diff/2012/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_aura.cc:57: NOTIMPLEMENTED();
Can this be removed now? Or are there more things to do here?

[oshima, 2011-10-06 20:01:05]

will land after syncing to msw's change.

http://codereview.chromium.org/8165016/diff/2012/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_aura.cc (right):

http://codereview.chromium.org/8165016/diff/2012/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_aura.cc:57: NOTIMPLEMENTED();
On 2011/10/06 19:53:59, sadrul wrote:
> Can this be removed now? Or are there more things to do here?
removed.

[commit-bot: I haz the power, 2011-10-06 21:15:01]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/8165016/4013

[msw, 2011-10-06 21:52:17]

http://codereview.chromium.org/8165016/diff/4013/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_aura.cc (right):

http://codereview.chromium.org/8165016/diff/4013/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_aura.cc:35: ClipboardData* data = NULL;
This is okay as a namespace global raw pointer? Shouldn't this be a Singleton or
a static class member of ClipboardData or something?

[commit-bot: I haz the power, 2011-10-06 22:23:46]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_clang, revision is 104363, job name
was 8165016-4013 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[oshima, 2011-10-06 22:53:47]

http://codereview.chromium.org/8165016/diff/4013/ui/base/clipboard/clipboard_...
File ui/base/clipboard/clipboard_aura.cc (right):

http://codereview.chromium.org/8165016/diff/4013/ui/base/clipboard/clipboard_...
ui/base/clipboard/clipboard_aura.cc:35: ClipboardData* data = NULL;
On 2011/10/06 21:52:17, msw wrote:
> This is okay as a namespace global raw pointer? Shouldn't this be a Singleton
or
> a static class member of ClipboardData or something?\

This is in anonymous namespace, so this is allowed. This is quite common
pattern. I expect whoever implements full clipboard feature will find out the
right way though.

[msw, 2011-10-06 23:03:04]

OK, LGTM.