Simple clipboard support for aura

ui/base/clipboard/clipboard_aura.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/clipboard/clipboard.h"
 
 #include "base/logging.h"
+#include "base/utf_string_conversions.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 namespace ui {
 
 namespace {
 const char kMimeTypeBitmap[] = "image/bmp";
 const char kMimeTypeWebkitSmartPaste[] = "chromium/x-webkit-paste";
+
+// A mimimum clipboard implementation for simple text cut&paste.
+class ClipboardData {
+ public:
+  ClipboardData() {}
+  virtual ~ClipboardData() {}
+
+  const std::string& text() const { return utf8_text_; }
+
+  void set_text(const std::string& text) {
+    utf8_text_ = text;
+  }
+
+ private:
+  std::string utf8_text_;
+
+  DISALLOW_COPY_AND_ASSIGN(ClipboardData);
+};
+
+ClipboardData* data = NULL;

[msw, 2011/10/06 21:52:17]

This is okay as a namespace global raw pointer? Shouldn't this be a Singleton or
a static class member of ClipboardData or something?

[oshima, 2011/10/06 22:53:47]

This is in anonymous namespace, so this is allowed. This is quite common
pattern. I expect whoever implements full clipboard feature will find out the
right way though.

+
+ClipboardData* GetClipboardData() {
+  if (!data)
+    data = new ClipboardData();
+  return data;
 }
 
+}  // namespace
+
 Clipboard::Clipboard() {
   NOTIMPLEMENTED();
 }
 
 Clipboard::~Clipboard() {
 }
 
 void Clipboard::WriteObjects(const ObjectMap& objects) {
-  NOTIMPLEMENTED();
+  for (ObjectMap::const_iterator iter = objects.begin();
+       iter != objects.end(); ++iter) {
+    DispatchObject(static_cast<ObjectType>(iter->first), iter->second);
+  }
 }
 
 
 void Clipboard::WriteObjects(const ObjectMap& objects,
                              base::ProcessHandle process) {
   NOTIMPLEMENTED();
 }
 
 void Clipboard::DidWriteURL(const std::string& utf8_text) {
   NOTIMPLEMENTED();
@@ skipping 10 matching lines @@
   NOTIMPLEMENTED();
   return false;
 }
 
 void Clipboard::ReadAvailableTypes(Buffer buffer, std::vector<string16>* types,
     bool* contains_filenames) const {
   NOTIMPLEMENTED();
 }
 
 void Clipboard::ReadText(Buffer buffer, string16* result) const {
-  NOTIMPLEMENTED();
+  *result = UTF8ToUTF16(GetClipboardData()->text());
 }
 
 void Clipboard::ReadAsciiText(Buffer buffer, std::string* result) const {
-  NOTIMPLEMENTED();
+  *result = GetClipboardData()->text();
 }
 
 void Clipboard::ReadHTML(Buffer buffer, string16* markup,
     std::string* src_url) const {
   NOTIMPLEMENTED();
 }
 
 SkBitmap Clipboard::ReadImage(Buffer buffer) const {
   NOTIMPLEMENTED();
   return SkBitmap();
@@ skipping 14 matching lines @@
 void Clipboard::ReadData(const std::string& format, std::string* result) {
   NOTIMPLEMENTED();
 }
 
 uint64 Clipboard::GetSequenceNumber() {
   NOTIMPLEMENTED();
   return 0;
 }
 
 void Clipboard::WriteText(const char* text_data, size_t text_len) {
-  NOTIMPLEMENTED();
+  GetClipboardData()->set_text(std::string(text_data, text_len));
 }
 
 void Clipboard::WriteHTML(const char* markup_data,
                           size_t markup_len,
                           const char* url_data,
                           size_t url_len) {
   NOTIMPLEMENTED();
 }
 
 void Clipboard::WriteBookmark(const char* title_data,
@@ skipping 35 matching lines @@
 Clipboard::FormatType Clipboard::GetBitmapFormatType() {
   return std::string(kMimeTypeBitmap);
 }
 
 // static
 Clipboard::FormatType Clipboard::GetWebKitSmartPasteFormatType() {
   return std::string(kMimeTypeWebkitSmartPaste);
 }
 
 }  // namespace ui