Issue 8163008: Add command line switch for enabling threaded compositing

Issue 8163008: Add command line switch for enabling threaded compositing (Closed)

Created:
9 years, 2 months ago by jamesr

Modified:
9 years, 2 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Avi (use Gerrit), dpranke+watch-content_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, Vangelis Kokkevis

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

Add command line switch for enabling threaded compositing This is a patch against the patch in http://codereview.chromium.org/8139020/ BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104623

Patch Set 1 #

Total comments: 1

Patch Set 2 : Set based on threaded flag in WebPreferences::Apply, add new member to WebPrefs IPC traits #

Patch Set 3 : Upload patch against correct base #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/content_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/content_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/common/view_messages.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view.cc	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webpreferences.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

This depends on http://codereview.chromium.org/8139020/ and http://trac.webkit.org/changeset/96766

9 years, 2 months ago (2011-10-06 01:08:54 UTC) #1

jamesr

Also note that without http://codereview.chromium.org/8089002/ starting chrome up with this flag will hit an ASSERT() ...

9 years, 2 months ago (2011-10-06 01:09:42 UTC) #2

jamesr

http://codereview.chromium.org/8163008/diff/1/webkit/glue/webpreferences.cc File webkit/glue/webpreferences.cc (right): http://codereview.chromium.org/8163008/diff/1/webkit/glue/webpreferences.cc#newcode253 webkit/glue/webpreferences.cc:253: settings->setUseThreadedCompositor(accelerated_compositing_enabled); whoops, i meant threaded_compositing_enabled here. oops!

9 years, 2 months ago (2011-10-06 23:13:05 UTC) #4

darin (slow to review)

9 years, 2 months ago (2011-10-07 07:21:32 UTC) #5

Sorry for not catching that!

On Thu, Oct 6, 2011 at 4:13 PM, <jamesr@chromium.org> wrote:

>
> http://codereview.chromium.**org/8163008/diff/1/webkit/**
>
glue/webpreferences.cc<http://codereview.chromium.org/8163008/diff/1/webkit/glue/webpreferences.cc>
> File webkit/glue/webpreferences.cc (right):
>
> http://codereview.chromium.**org/8163008/diff/1/webkit/**
>
glue/webpreferences.cc#**newcode253<http://codereview.chromium.org/8163008/diff/1/webkit/glue/webpreferences.cc#newcode253>
> webkit/glue/webpreferences.cc:**253:
> settings->**setUseThreadedCompositor(**accelerated_compositing_**enabled);
> whoops, i meant threaded_compositing_enabled here. oops!
>
>
http://codereview.chromium.**org/8163008/<http://codereview.chromium.org/8163...
>

Expand Messages | Collapse Messages