Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 8159001: Update third_party/psutil and fix the licence issue with it. (Closed)

Created:
9 years, 2 months ago by imasaki1
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update third_party/psutil and fix the licence issue with it. BUG=98456 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104425

Patch Set 1 #

Patch Set 2 : remove the suppression and unnecessary files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6607 lines, -2353 lines) Patch
M third_party/psutil/CREDITS View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/psutil/HISTORY View 1 chunk +95 lines, -0 lines 0 comments Download
M third_party/psutil/MANIFEST.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/psutil/README View 3 chunks +12 lines, -10 lines 0 comments Download
M third_party/psutil/README.chromium View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/psutil/docs/BUILDING.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/psutil/docs/class_diagram.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/psutil/docs/documentation.html View 1 chunk +155 lines, -65 lines 0 comments Download
M third_party/psutil/docs/index.html View 1 2 chunks +83 lines, -57 lines 0 comments Download
A third_party/psutil/examples/disk_usage.py View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/psutil/examples/iotop.py View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/psutil/examples/killall.py View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/psutil/examples/process_detail.py View 1 chunk +122 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/__init__.py View 12 chunks +405 lines, -126 lines 0 comments Download
A third_party/psutil/psutil/_common.py View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_compat.py View 1 chunk +154 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/_psbsd.py View 6 chunks +128 lines, -55 lines 0 comments Download
M third_party/psutil/psutil/_pslinux.py View 17 chunks +476 lines, -196 lines 0 comments Download
M third_party/psutil/psutil/_psmswindows.py View 8 chunks +150 lines, -72 lines 0 comments Download
M third_party/psutil/psutil/_psosx.py View 4 chunks +132 lines, -56 lines 0 comments Download
M third_party/psutil/psutil/_psposix.py View 3 chunks +85 lines, -7 lines 0 comments Download
M third_party/psutil/psutil/_psutil_bsd.h View 3 chunks +16 lines, -4 lines 0 comments Download
M third_party/psutil/psutil/_psutil_bsd.c View 12 chunks +530 lines, -137 lines 0 comments Download
A third_party/psutil/psutil/_psutil_common.h View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_common.c View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_linux.h View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_linux.c View 1 chunk +211 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/_psutil_mswindows.h View 2 chunks +20 lines, -8 lines 0 comments Download
M third_party/psutil/psutil/_psutil_mswindows.c View 22 chunks +644 lines, -402 lines 0 comments Download
M third_party/psutil/psutil/_psutil_osx.h View 3 chunks +17 lines, -5 lines 0 comments Download
M third_party/psutil/psutil/_psutil_osx.c View 16 chunks +951 lines, -210 lines 0 comments Download
A third_party/psutil/psutil/_psutil_posix.h View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_posix.c View 1 chunk +134 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/arch/bsd/process_info.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/psutil/psutil/arch/bsd/process_info.c View 2 chunks +27 lines, -1 line 0 comments Download
A third_party/psutil/psutil/arch/mswindows/ntextapi.h View 1 chunk +183 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/arch/mswindows/process_handles.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/arch/mswindows/process_handles.c View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/psutil/psutil/arch/mswindows/process_info.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/psutil/psutil/arch/mswindows/process_info.c View 13 chunks +90 lines, -79 lines 0 comments Download
M third_party/psutil/psutil/arch/mswindows/security.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/psutil/psutil/arch/mswindows/security.c View 1 5 chunks +12 lines, -5 lines 0 comments Download
M third_party/psutil/psutil/arch/osx/process_info.h View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/psutil/psutil/arch/osx/process_info.c View 4 chunks +101 lines, -148 lines 0 comments Download
D third_party/psutil/psutil/compat.py View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/psutil/psutil/error.py View 2 chunks +24 lines, -2 lines 0 comments Download
M third_party/psutil/setup.py View 4 chunks +57 lines, -32 lines 0 comments Download
M third_party/psutil/test/_bsd.py View 8 chunks +48 lines, -19 lines 0 comments Download
M third_party/psutil/test/_linux.py View 2 chunks +32 lines, -5 lines 0 comments Download
M third_party/psutil/test/_osx.py View 3 chunks +35 lines, -8 lines 0 comments Download
M third_party/psutil/test/_posix.py View 8 chunks +29 lines, -20 lines 0 comments Download
M third_party/psutil/test/_windows.py View 4 chunks +31 lines, -4 lines 0 comments Download
M third_party/psutil/test/test_memory_leaks.py View 6 chunks +102 lines, -79 lines 0 comments Download
M third_party/psutil/test/test_psutil.py View 28 chunks +848 lines, -417 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imasaki1
Thank you!
9 years, 2 months ago (2011-10-05 20:43:11 UTC) #1
Paweł Hajdan Jr.
Please remove the suppression from tools/checklicenses/checklicenses.py
9 years, 2 months ago (2011-10-05 21:10:52 UTC) #2
imasaki1
Thanks. Please let me know if this looks OK.
9 years, 2 months ago (2011-10-06 22:05:58 UTC) #3
Paweł Hajdan Jr.
checklicenses LGTM; I didn't review any other files
9 years, 2 months ago (2011-10-06 22:19:06 UTC) #4
dennis_jeffrey
Hey Kenji - I started looking through a few of the other files in this ...
9 years, 2 months ago (2011-10-06 22:30:36 UTC) #5
imasaki1
On 2011/10/06 22:30:36, dennis_jeffrey wrote: > Hey Kenji - I started looking through a few ...
9 years, 2 months ago (2011-10-06 22:41:13 UTC) #6
dennis_jeffrey
rubber-stamp LGTM.
9 years, 2 months ago (2011-10-06 22:42:47 UTC) #7
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/imasaki@chromium.org/8159001/4001
9 years, 2 months ago (2011-10-07 01:30:25 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 01:30:41 UTC) #9
Can't apply patch for file third_party/psutil/psutil/arch/mswindows/security.c.
While running patch -p1 --forward --force;
patching file third_party/psutil/psutil/arch/mswindows/security.c
Hunk #2 FAILED at 30.
1 out of 5 hunks FAILED -- saving rejects to file
third_party/psutil/psutil/arch/mswindows/security.c.rej

Powered by Google App Engine
This is Rietveld 408576698