| 
        
       | 
      
        
  
  [Mac] Restore the old bookmark menus now that the experiment is over.
This reverts, with minor rebasing, the following commits:
r95609 - "[Mac] Replace the custom bookmark menus with native NSMenus."
r95901 - "[Mac] Delete more bookmark bar folder code. This removes things that were missed last time."
r99312 - "[Mac] Remove the Open All items from the bottom of bookmark bar folder menus."
r99423 - "[Mac] Fix the off-the-side chevron menu."
BUG= 93674
TEST=Visual and covered by unit_tests
Committed:  http://src.chromium.org/viewvc/chrome?view=rev&revision=103959
   
  
  
  
    
  
  
    
       | 
      Unified diffs | 
      Side-by-side diffs | 
      Delta from patch set | 
      Stats (+12856 lines, -511 lines) | 
      Patch | 
     
    
      
          | 
        A | 
        
          
            chrome/app/nibs/BookmarkBarFolderWindow.xib
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +2593 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/app/theme/menu_hierarchy_arrow.pdf
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +1517 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/app/theme/menu_overflow_down.pdf
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +1529 lines, -4 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/app/theme/menu_overflow_up.pdf
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +1558 lines, -2 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          3 chunks | 
          +72 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          21 chunks | 
          +301 lines, -11 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          8 chunks | 
          +359 lines, -21 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +31 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +29 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +24 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +198 lines, -29 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +1949 lines, -62 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +1534 lines, -148 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +78 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +173 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_hover_state_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +77 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +21 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +206 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +151 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +33 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +90 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        A | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +49 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          3 chunks | 
          +10 lines, -8 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_bar_unittest_helper.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +9 lines, -20 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_button.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +6 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          3 chunks | 
          +69 lines, -1 line | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +14 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          4 chunks | 
          +52 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +25 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          3 chunks | 
          +27 lines, -14 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          6 chunks | 
          +13 lines, -41 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          8 chunks | 
          +39 lines, -71 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          3 chunks | 
          +2 lines, -46 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +2 lines, -17 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +0 lines, -16 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/chrome_browser.gypi
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +8 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/chrome_dll.gypi
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          2 chunks | 
          +4 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
      
          | 
        M | 
        
          
            chrome/chrome_tests.gypi
          
         | 
        
          
            View
          
         | 
        
        
         | 
        
          1 chunk | 
          +4 lines, -0 lines | 
        
        
          
            0 comments
            
            
          
         | 
        
          
            Download
          
         | 
       
    
   
  
  
 
  
   
  
    
  
  
  
    
    Total messages: 3 (0 generated)
     
  
  
       |