[Mac] Restore the old bookmark menus now that the experiment is over.

chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AppKit/AppKit.h>
 
-#include "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"
-
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/mac/nsimage_cache.h"
 
 BookmarkMenuBridge::BookmarkMenuBridge(Profile* profile,
                                        NSMenu *menu)
-    : menu_is_valid_(false),
-      root_node_(NULL),
-      off_the_side_node_start_index_(0),
+    : menuIsValid_(false),
       profile_(profile),
       controller_([[BookmarkMenuCocoaController alloc] initWithBridge:this
                                                               andMenu:menu]) {
-  if (GetBookmarkModel())
-    ObserveBookmarkModel();
-}
-
-BookmarkMenuBridge::BookmarkMenuBridge(const BookmarkNode* root_node,
-                                       Profile* profile,
-                                       NSMenu* menu)
-    : menu_is_valid_(false),
-      root_node_(root_node),
-      off_the_side_node_start_index_(0),
-      profile_(profile),
-      controller_([[BookmarkMenuCocoaController alloc] initWithBridge:this
-                                                              andMenu:menu]) {
   if (GetBookmarkModel())
     ObserveBookmarkModel();
 }
 
 BookmarkMenuBridge::~BookmarkMenuBridge() {
   BookmarkModel *model = GetBookmarkModel();
   if (model)
     model->RemoveObserver(this);
+  [controller_ release];
 }
 
 NSMenu* BookmarkMenuBridge::BookmarkMenu() {
   return [controller_ menu];
 }
 
 void BookmarkMenuBridge::Loaded(BookmarkModel* model, bool ids_reassigned) {
   InvalidateMenu();
 }
 
 void BookmarkMenuBridge::UpdateMenu(NSMenu* bookmark_menu) {
   UpdateMenuInternal(bookmark_menu, false);
 }
 
 void BookmarkMenuBridge::UpdateSubMenu(NSMenu* bookmark_menu) {
   UpdateMenuInternal(bookmark_menu, true);
 }
 
 void BookmarkMenuBridge::UpdateMenuInternal(NSMenu* bookmark_menu,
                                             bool is_submenu) {
   DCHECK(bookmark_menu);
-  if (menu_is_valid_)
+  if (menuIsValid_)
     return;
   BookmarkModel* model = GetBookmarkModel();
   if (!model || !model->IsLoaded())
     return;
 
   if (!folder_image_) {
     ResourceBundle& rb = ResourceBundle::GetSharedInstance();
     folder_image_.reset(
         [rb.GetNativeImageNamed(IDR_BOOKMARK_BAR_FOLDER) retain]);
   }
 
   ClearBookmarkMenu(bookmark_menu);
 
-  if (!root_node_) {
-    // Add bookmark bar items, if any.
-    const BookmarkNode* bar_node = model->bookmark_bar_node();
-    CHECK(bar_node);
-    if (!bar_node->empty()) {
-      [bookmark_menu addItem:[NSMenuItem separatorItem]];
-      AddNodeToMenu(bar_node, bookmark_menu, !is_submenu);
-    }
-
-    // If the "Other Bookmarks" folder has any content, make a submenu for it
-    // and fill it in.
-    if (!model->other_node()->empty()) {
-      NSString* other_items_title =
-          l10n_util::GetNSString(IDS_BOOKMARK_BAR_OTHER_FOLDER_NAME);
-      [bookmark_menu addItem:[NSMenuItem separatorItem]];
-      AddNodeAsSubmenu(bookmark_menu,
-                       model->other_node(),
-                       other_items_title,
-                       !is_submenu);
-    }
-  } else {
-    AddNodeToMenu(root_node_, bookmark_menu, false);
+  // Add bookmark bar items, if any.
+  const BookmarkNode* barNode = model->bookmark_bar_node();
+  CHECK(barNode);
+  if (!barNode->empty()) {
+    [bookmark_menu addItem:[NSMenuItem separatorItem]];
+    AddNodeToMenu(barNode, bookmark_menu, !is_submenu);
   }
 
-  menu_is_valid_ = true;
+  // If the "Other Bookmarks" folder has any content, make a submenu for it and
+  // fill it in.
+  if (!model->other_node()->empty()) {
+    NSString* other_items_title =
+        l10n_util::GetNSString(IDS_BOOKMARK_BAR_OTHER_FOLDER_NAME);
+    [bookmark_menu addItem:[NSMenuItem separatorItem]];
+    AddNodeAsSubmenu(bookmark_menu,
+                     model->other_node(),
+                     other_items_title,
+                     !is_submenu);
+  }
+
+  menuIsValid_ = true;
 }
 
 void BookmarkMenuBridge::BookmarkModelBeingDeleted(BookmarkModel* model) {
   NSMenu* bookmark_menu = BookmarkMenu();
   if (bookmark_menu == nil)
     return;
 
   ClearBookmarkMenu(bookmark_menu);
 }
 
@@ skipping 97 matching lines @@
                                       action:nil
                                keyEquivalent:@""] autorelease];
   [items setImage:folder_image_];
   [menu addItem:items];
   NSMenu* other_submenu = [[[NSMenu alloc] initWithTitle:title]
                             autorelease];
   [menu setSubmenu:other_submenu forItem:items];
   AddNodeToMenu(node, other_submenu, add_extra_items);
 }
 
-void BookmarkMenuBridge::AddNodeToMenu(const BookmarkNode* node,
-                                       NSMenu* menu,
+// TODO(jrg): limit the number of bookmarks in the menubar?
+void BookmarkMenuBridge::AddNodeToMenu(const BookmarkNode* node, NSMenu* menu,
                                        bool add_extra_items) {
-  AddNodeToMenuRecursive(node, menu, add_extra_items, 0);
-}
-
-void BookmarkMenuBridge::AddNodeToMenuRecursive(const BookmarkNode* node,
-                                                NSMenu* menu,
-                                                bool add_extra_items,
-                                                int recursion_depth) {
   int child_count = node->child_count();
   if (!child_count) {
     NSString* empty_string = l10n_util::GetNSString(IDS_MENU_EMPTY_SUBMENU);
     NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:empty_string
                                                    action:nil
                                             keyEquivalent:@""] autorelease];
     [menu addItem:item];
-  } else {
-    // If this is the first recursive pass, start adding children from the
-    // start index, which defaults to 0.
-    const int start = recursion_depth == 0 ? off_the_side_node_start_index_ : 0;
-    for (int i = start; i < child_count; i++) {
-      const BookmarkNode* child = node->GetChild(i);
-      NSString* title = [BookmarkMenuCocoaController menuTitleForNode:child];
-      NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:title
-                                                     action:nil
-                                              keyEquivalent:@""] autorelease];
-      [menu addItem:item];
-      bookmark_nodes_[child] = item;
-      if (child->is_folder()) {
-        [item setImage:folder_image_];
-        NSMenu* submenu = [[[NSMenu alloc] initWithTitle:title] autorelease];
-        [menu setSubmenu:submenu forItem:item];
-        AddNodeToMenuRecursive(child, submenu, add_extra_items,
-                               recursion_depth + 1);  // Recursive call.
-      } else {
-        ConfigureMenuItem(child, item, false);
-      }
+  } else for (int i = 0; i < child_count; i++) {
+    const BookmarkNode* child = node->GetChild(i);
+    NSString* title = [BookmarkMenuCocoaController menuTitleForNode:child];
+    NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:title
+                                                   action:nil
+                                            keyEquivalent:@""] autorelease];
+    [menu addItem:item];
+    bookmark_nodes_[child] = item;
+    if (child->is_folder()) {
+      [item setImage:folder_image_];
+      NSMenu* submenu = [[[NSMenu alloc] initWithTitle:title] autorelease];
+      [menu setSubmenu:submenu forItem:item];
+      AddNodeToMenu(child, submenu, add_extra_items);  // recursive call
+    } else {
+      ConfigureMenuItem(child, item, false);
     }
   }
 
   if (add_extra_items) {
     // Add menus for 'Open All Bookmarks'.
     [menu addItem:[NSMenuItem separatorItem]];
     bool enabled = child_count != 0;
     AddItemToMenu(IDC_BOOKMARK_BAR_OPEN_ALL,
                   IDS_BOOKMARK_BAR_OPEN_ALL,
                   node, menu, enabled);
@@ skipping 60 matching lines @@
 
 NSMenuItem* BookmarkMenuBridge::MenuItemForNode(const BookmarkNode* node) {
   if (!node)
     return nil;
   std::map<const BookmarkNode*, NSMenuItem*>::iterator it =
       bookmark_nodes_.find(node);
   if (it == bookmark_nodes_.end())
     return nil;
   return it->second;
 }