Issue 8139026: Fix Kraken segfaults on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8139026: Fix Kraken segfaults on ARM. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix Kraken segfaults on ARM. DoStoreKeyedFastElement was passing incorrect slot address (off by 1) to the RecordWrite. R=erik.corry@gmail.com BUG=v8:1742 Committed: http://code.google.com/p/v8/source/detail?r=9528

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 2 months ago (2011-10-05 10:48:20 UTC) #2

LGTM

http://codereview.chromium.org/8139026/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/8139026/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3366: __ add(key, scratch,
Operand(FixedArray::kHeaderSize - 1));
Instead of 1 how about kHeapObjectTag?

Expand Messages | Collapse Messages