src/arm/lithium-codegen-arm.cc - Issue 8139026: Fix Kraken segfaults on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 8139026: Fix Kraken segfaults on ARM. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index f6750a299d9434201c7986c0d06bae43e1aad6a4..cc3262a055b65ff8119900f2a6950109877f302f 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -3363,7 +3363,7 @@ void LCodeGen::DoStoreKeyedFastElement(LStoreKeyedFastElement* instr) {

if (instr->hydrogen()->NeedsWriteBarrier()) {

// Compute address of modified element and store it into key register.

- __ add(key, scratch, Operand(FixedArray::kHeaderSize));

+ __ add(key, scratch, Operand(FixedArray::kHeaderSize - 1));

Erik Corry 2011/10/05 10:48:20 Instead of 1 how about kHeapObjectTag?

__ RecordWrite(elements, key, value, kLRHasBeenSaved, kSaveFPRegs);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »