Rename ScopedHDC to ScopedCreateDC

* Rename ScopedHDC to ScopedCreateDC
* Use ScopedSelectObject for changed files
BUG=99139
TEST=no user visible change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104441

[sanjeevr, 2011-10-05 17:34:06]

LGTM for the cloud print code.

http://codereview.chromium.org/8139022/diff/1/base/win/scoped_hdc.h
File base/win/scoped_hdc.h (right):

http://codereview.chromium.org/8139022/diff/1/base/win/scoped_hdc.h#newcode42
base/win/scoped_hdc.h:42: // CreateCompatibleDC.
This comment should be CreateCompatibleDC, CreateDC and CreateIC.

[yosin_UTC9, 2011-10-06 03:35:35]

Hi guys,
Could you review my changes?
Thanks in advance.
-yosi

http://codereview.chromium.org/8139022/diff/1/base/win/scoped_hdc.h
File base/win/scoped_hdc.h (right):

http://codereview.chromium.org/8139022/diff/1/base/win/scoped_hdc.h#newcode42
base/win/scoped_hdc.h:42: // CreateCompatibleDC.
On 2011/10/05 17:34:06, sanjeevr wrote:
> This comment should be CreateCompatibleDC, CreateDC and CreateIC.

Done.

[Mark Mentovai, 2011-10-06 03:52:24]

This will be LG once it has a correct check-in comment.

http://codereview.chromium.org/8139022/diff/3001/base/win/scoped_hdc.h
File base/win/scoped_hdc.h (right):

http://codereview.chromium.org/8139022/diff/3001/base/win/scoped_hdc.h#newcode1
base/win/scoped_hdc.h:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
The issue description becomes part of the check-in comment. Please revise it to
be a description of this change. Don’t put reviewer instructions in there, those
belong in the e-mail message you send out along with your patch.

[yosin_UTC9, 2011-10-06 04:34:17]

On 2011/10/06 03:52:24, Mark Mentovai wrote:
> This will be LG once it has a correct check-in comment.
> 
> http://codereview.chromium.org/8139022/diff/3001/base/win/scoped_hdc.h
> File base/win/scoped_hdc.h (right):
> 
>
http://codereview.chromium.org/8139022/diff/3001/base/win/scoped_hdc.h#newcode1
> base/win/scoped_hdc.h:1: // Copyright (c) 2011 The Chromium Authors. All
rights
> reserved.
> The issue description becomes part of the check-in comment. Please revise it
to
> be a description of this change. Don’t put reviewer instructions in there,
those
> belong in the e-mail message you send out along with your patch.

Update "Description" as Mark suggested.
Thanks.

[yosin_UTC9, 2011-10-06 04:37:00]

Sorry for noise. Move reviewers instructions from description to email.

To: sky@
* chrome/browser/aeropeek_manager.cc
* chrome/browser/ui/window_snapshot/window_snapshot_win.cc
* chrome/renderer/print_web_view_helper_win.cc
* ui/gfx/native_theme_win.cc

To: kmadhusu@
* printing/emf_win_unittest.cc

DONE To: mark@ and sky@
DONE * base/scoped_hdc.h

DONE To: sanjeevr@
DONE * chrome/service/cloud_print/print_system_win.cc

[Mark Mentovai, 2011-10-06 05:08:22]

LGTM for base OWNERS approval. I also reviewed the entire change.

[sky, 2011-10-06 05:16:10]

LGTM

[kmadhusu, 2011-10-06 15:44:22]

lgtm

[commit-bot: I haz the power, 2011-10-07 00:53:08]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/8139022/3001

[commit-bot: I haz the power, 2011-10-07 02:47:42]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 104418, job name
was 8139022-3001 (retry) (previous was lost) (previous was lost) (previous was
lost).

[commit-bot: I haz the power, 2011-10-07 03:21:45]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/8139022/3001

[commit-bot: I haz the power, 2011-10-07 04:24:17]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 104437, job name
was 8139022-3001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2011-10-07 04:38:29]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/8139022/3001

[commit-bot: I haz the power, 2011-10-07 05:40:28]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 104439, job name
was 8139022-3001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).