Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7911)

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 8139022: Rename ScopedHDC to ScopedCreateDC (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update a comment of ScopedCreateDC Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/print_system_win.cc
diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc
index 5566b1af7be53d12cddb7ea76afa5ba0301d42c0..29f747f24fea05248e0ca85f20bfffdd24cd5afc 100644
--- a/chrome/service/cloud_print/print_system_win.cc
+++ b/chrome/service/cloud_print/print_system_win.cc
@@ -131,6 +131,7 @@ class PrintSystemWatcherWin : public base::win::ObjectWatcher::Delegate {
class Delegate {
public:
+ virtual ~Delegate() {}
virtual void OnPrinterAdded() = 0;
virtual void OnPrinterDeleted() = 0;
virtual void OnPrinterChanged() = 0;
@@ -363,6 +364,7 @@ class PrintSystemWin : public PrintSystem {
print_data_mime_type, printer_name, job_title,
delegate);
}
+
private:
// We use a Core class because we want a separate RefCountedThreadSafe
// implementation for ServiceUtilityProcessHost::Client.
@@ -627,7 +629,7 @@ class PrintSystemWin : public PrintSystem {
PlatformJobId job_id_;
PrintSystem::JobSpooler::Delegate* delegate_;
int saved_dc_;
- base::win::ScopedHDC printer_dc_;
+ base::win::ScopedCreateDC printer_dc_;
FilePath print_data_file_path_;
base::win::ScopedHandle job_progress_event_;
base::win::ObjectWatcher job_progress_watcher_;
@@ -675,6 +677,7 @@ class PrintSystemWin : public PrintSystem {
callback_.reset();
Release();
}
+
private:
// Called on the service process IO thread.
void GetPrinterCapsAndDefaultsImpl(

Powered by Google App Engine
This is Rietveld 408576698