Don't reopen avatar bubble view on second click

Don't reopen avatar bubble view on second click

If user opened the avatar bubble view then clicked on the avatar button the avatar menu would close then reopen.

With this change we keep track of the open bubble and prevent it from reopening.

BUG=97146
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104057

[Peter Kasting, 2011-10-05 01:22:51]

LGTM

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/avatar_...
File chrome/browser/ui/views/avatar_menu_button.cc (right):

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/avatar_...
chrome/browser/ui/views/avatar_menu_button.cc:76: if (bubble_)
Nit: Maybe this should just call OnBubbleClosing()?

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/bubble/...
File chrome/browser/ui/views/bubble/bubble.h (right):

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/bubble/...
chrome/browser/ui/views/bubble/bubble.h:93: virtual void OnBubbleClosing(Bubble*
bubble, bool closed_by_escape) = 0;
Nit: You don't seem to use either of these args, so why not omit them for now? 
We can add them later if needed.

[sail, 2011-10-05 01:32:10]

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/avatar_...
File chrome/browser/ui/views/avatar_menu_button.cc (right):

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/avatar_...
chrome/browser/ui/views/avatar_menu_button.cc:76: if (bubble_)
On 2011/10/05 01:22:51, Peter Kasting wrote:
> Nit: Maybe this should just call OnBubbleClosing()?

Done.

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/bubble/...
File chrome/browser/ui/views/bubble/bubble.h (right):

http://codereview.chromium.org/8138019/diff/1/chrome/browser/ui/views/bubble/...
chrome/browser/ui/views/bubble/bubble.h:93: virtual void OnBubbleClosing(Bubble*
bubble, bool closed_by_escape) = 0;
On 2011/10/05 01:22:51, Peter Kasting wrote:
> Nit: You don't seem to use either of these args, so why not omit them for now?

> We can add them later if needed.

Done.

[commit-bot: I haz the power, 2011-10-05 01:32:19]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8138019/8

[commit-bot: I haz the power, 2011-10-05 03:24:50]

Change committed as 104057