chrome/browser/ui/webui/print_preview_ui_unittest.cc - Issue 8136027: Print Preview: Make print preview tab modal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview_ui_unittest.cc

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: address preview tab navigation, cancelling print to pdf issues Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/print_preview_ui.h ('K') | « chrome/browser/ui/webui/print_preview_ui_uitest.cc ('k') | chrome/browser/ui/webui/web_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview_ui_unittest.cc

===================================================================

--- chrome/browser/ui/webui/print_preview_ui_unittest.cc (revision 105366)

+++ chrome/browser/ui/webui/print_preview_ui_unittest.cc (working copy)

@@ -8,6 +8,7 @@

#include "base/memory/ref_counted_memory.h"

#include "chrome/browser/printing/print_preview_tab_controller.h"

#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/constrained_window_tab_helper.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/browser/ui/webui/print_preview_ui.h"

#include "chrome/common/chrome_switches.h"

@@ -21,6 +22,10 @@

const unsigned char blob1[] =

"12346102356120394751634516591348710478123649165419234519234512349134";

+size_t GetConstrainedWindowCount(TabContentsWrapper* tab) {

+ return tab->constrained_window_tab_helper()->constrained_window_count();

} // namespace

typedef BrowserWithTestWindowTest PrintPreviewUITest;

@@ -45,7 +50,7 @@

controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

- EXPECT_EQ(2, browser()->tab_count());

+ EXPECT_EQ(1, browser()->tab_count());

kmadhusu 2011/10/14 00:21:09 EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_

Lei Zhang 2011/10/14 20:31:27 Done.

PrintPreviewUI* preview_ui =

reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());

@@ -105,7 +110,8 @@

controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

- EXPECT_EQ(2, browser()->tab_count());

+ EXPECT_EQ(1, browser()->tab_count());

+ EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_tab));

PrintPreviewUI* preview_ui =

reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());

@@ -172,7 +178,8 @@

controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

- EXPECT_EQ(2, browser()->tab_count());

+ EXPECT_EQ(1, browser()->tab_count());

+ EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_tab));

PrintPreviewUI* preview_ui =

reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());