Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4903)

Unified Diff: chrome/browser/ui/webui/print_preview_ui.h

Issue 8136027: Print Preview: Make print preview tab modal. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: address preview tab navigation, cancelling print to pdf issues Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview_ui.h
===================================================================
--- chrome/browser/ui/webui/print_preview_ui.h (revision 105366)
+++ chrome/browser/ui/webui/print_preview_ui.h (working copy)
@@ -12,7 +12,7 @@
#include "base/memory/ref_counted_memory.h"
#include "base/time.h"
#include "chrome/browser/printing/print_preview_data_service.h"
-#include "chrome/browser/ui/webui/chrome_web_ui.h"
+#include "chrome/browser/ui/webui/constrained_html_ui.h"
class PrintPreviewDataService;
class PrintPreviewHandler;
@@ -22,7 +22,7 @@
struct PageSizeMargins;
}
-class PrintPreviewUI : public ChromeWebUI {
+class PrintPreviewUI : public ConstrainedHtmlUI {
public:
explicit PrintPreviewUI(TabContents* contents);
virtual ~PrintPreviewUI();
@@ -96,13 +96,13 @@
// Notifies the Web UI that the print preview failed to render.
void OnPrintPreviewFailed();
+ // Notified the Web UI that this print preview tab has crashed.
+ void OnPrintPreviewTabCrashed();
+
// Notifies the Web UI that initiator tab is closed, so we can disable all the
// controls that need the initiator tab for generating the preview data.
void OnInitiatorTabClosed();
- // Notifies the Web UI that the initiator tab has crashed.
- void OnInitiatorTabCrashed();
-
// Notifies the Web UI renderer that file selection has been cancelled.
void OnFileSelectionCancelled();
@@ -113,6 +113,12 @@
// Notifies the Web UI to cancel the pending preview request.
void OnCancelPendingPreviewRequest();
+ // Hide the print preview tab.
+ void HidePreviewTab();
kmadhusu 2011/10/14 00:21:09 nit: OnHidePreviewTab() and OnClosePrintPreviewTab
Lei Zhang 2011/10/14 20:31:27 Done.
+
+ // Close the print preview tab.
+ void ClosePrintPreviewTab();
+
private:
FRIEND_TEST_ALL_PREFIXES(PrintPreviewTabControllerUnitTest,
TitleAfterReload);

Powered by Google App Engine
This is Rietveld 408576698