Refactor downloads into a ProfileKeyedService.

content/browser/download/download_manager.h

Index: content/browser/download/download_manager.h
diff --git a/content/browser/download/download_manager.h b/content/browser/download/download_manager.h
index 822c1f7d24911aef5791bafada80308dbe078e16..b4590664f516cc9783fb6843799b26d8f76d052e 100644
--- a/content/browser/download/download_manager.h
+++ b/content/browser/download/download_manager.h
@@ -300,8 +300,9 @@ class CONTENT_EXPORT DownloadManager
 
   // For testing.
   friend class DownloadManagerTest;
-  friend class MockDownloadManager;
+  friend class DownloadService;

[jam, 2011/10/05 19:27:13]

two issues come to mind:
1) this isn't a test class
2) we shouldn't friend chrome classes in content. what methods does it need?

[Randy Smith (Not in Mondays), 2011/10/08 23:46:54]

I'm pretty sure I've cleaned up both issues (by giving up on enforcing the
restriction that only tests call SetDownloadManagerDelegate() as the compile
level, but that's ok).  Let me know what you think.

   friend class DownloadTest;
+  friend class MockDownloadManager;
 
   friend class base::RefCountedThreadSafe<DownloadManager,
                                           BrowserThread::DeleteOnUIThread>;