Refactor downloads into a ProfileKeyedService.

content/browser/download/download_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active browser context in Chrome.
 //
 // Download observers:
@@ skipping 282 matching lines @@
   DownloadItem* GetActiveDownloadItem(int id);
 
   DownloadManagerDelegate* delegate() const { return delegate_; }
 
  private:
   typedef std::set<DownloadItem*> DownloadSet;
   typedef base::hash_map<int64, DownloadItem*> DownloadMap;
 
   // For testing.
   friend class DownloadManagerTest;
+  friend class DownloadService;

[jam, 2011/10/05 19:27:13]

two issues come to mind:
1) this isn't a test class
2) we shouldn't friend chrome classes in content. what methods does it need?

[Randy Smith (Not in Mondays), 2011/10/08 23:46:54]

I'm pretty sure I've cleaned up both issues (by giving up on enforcing the
restriction that only tests call SetDownloadManagerDelegate() as the compile
level, but that's ok).  Let me know what you think.

+  friend class DownloadTest;
   friend class MockDownloadManager;
-  friend class DownloadTest;
 
   friend class base::RefCountedThreadSafe<DownloadManager,
                                           BrowserThread::DeleteOnUIThread>;
   friend struct BrowserThread::DeleteOnThread<BrowserThread::UI>;
   friend class DeleteTask<DownloadManager>;
 
   void set_delegate(DownloadManagerDelegate* delegate) { delegate_ = delegate; }
 
   virtual ~DownloadManager();
 
@@ skipping 112 matching lines @@
   DownloadManagerDelegate* delegate_;
 
   // TODO(rdsmith): Remove when http://crbug.com/85408 is fixed.
   // For debugging only.
   int64 largest_db_handle_in_history_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_