Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 8133001: Remove |file_list| parameter from |TryChange()|. (Closed)

Created:
9 years, 2 months ago by Alexei Svitkine (slow)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Remove |file_list| parameter from |TryChange()|. BUG=none TEST=Run unit tests - they should still pass. Run gcl try and git try and make sure there are no errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104067

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M gcl.py View 2 chunks +0 lines, -3 lines 0 comments Download
M git_try.py View 1 chunk +1 line, -1 line 0 comments Download
M trychange.py View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
9 years, 2 months ago (2011-10-04 14:14:44 UTC) #1
M-A Ruel
lgtm with nit http://codereview.chromium.org/8133001/diff/2001/trychange.py File trychange.py (right): http://codereview.chromium.org/8133001/diff/2001/trychange.py#newcode499 trychange.py:499: change: Change object corresponding to the ...
9 years, 2 months ago (2011-10-04 14:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8133001/5
9 years, 2 months ago (2011-10-04 14:55:59 UTC) #3
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8133001/5
9 years, 2 months ago (2011-10-05 05:32:11 UTC) #4
commit-bot: I haz the power
Change committed as 104067
9 years, 2 months ago (2011-10-05 05:38:39 UTC) #5
Bernhard Bauer
I think this broke `git try -- upstream_branch`. Before this CL, we would pass in ...
9 years, 2 months ago (2011-10-05 18:04:40 UTC) #6
Alexei Svitkine (slow)
9 years, 2 months ago (2011-10-05 18:12:18 UTC) #7
On 2011/10/05 18:04:40, Bernhard Bauer wrote:
> I think this broke `git try -- upstream_branch`. Before this CL, we would pass
> in an empty |file_list| from git_try.py, and now we get the file list from the
> change, but that's before we have parsed the arguments, so we ignore the
> `--upstream_branch` value and look at the `git cl upstream` one instead.

Looking...

Powered by Google App Engine
This is Rietveld 408576698