Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: gcl.py

Issue 8133001: Remove |file_list| parameter from |TryChange()|. (Closed) Base URL: http://src.chromium.org/svn/trunk/tools/depot_tools/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | git_try.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """\ 6 """\
7 Wrapper script around Rietveld's upload.py that simplifies working with groups 7 Wrapper script around Rietveld's upload.py that simplifies working with groups
8 of files. 8 of files.
9 """ 9 """
10 10
(...skipping 942 matching lines...) Expand 10 before | Expand all | Expand 10 after
953 return 1 953 return 1
954 ErrorExit("You need to install trychange.py to use the try server.") 954 ErrorExit("You need to install trychange.py to use the try server.")
955 955
956 trychange_args = [] 956 trychange_args = []
957 if change_info: 957 if change_info:
958 trychange_args.extend(['--name', change_info.name]) 958 trychange_args.extend(['--name', change_info.name])
959 if change_info.issue: 959 if change_info.issue:
960 trychange_args.extend(["--issue", str(change_info.issue)]) 960 trychange_args.extend(["--issue", str(change_info.issue)])
961 if change_info.patchset: 961 if change_info.patchset:
962 trychange_args.extend(["--patchset", str(change_info.patchset)]) 962 trychange_args.extend(["--patchset", str(change_info.patchset)])
963 file_list = change_info.GetFileNames()
964 change = presubmit_support.SvnChange(change_info.name, 963 change = presubmit_support.SvnChange(change_info.name,
965 change_info.description, 964 change_info.description,
966 change_info.GetLocalRoot(), 965 change_info.GetLocalRoot(),
967 change_info.GetFiles(), 966 change_info.GetFiles(),
968 change_info.issue, 967 change_info.issue,
969 change_info.patchset, 968 change_info.patchset,
970 None) 969 None)
971 else: 970 else:
972 file_list = []
973 change = None 971 change = None
974 972
975 trychange_args.extend(args) 973 trychange_args.extend(args)
976 return trychange.TryChange( 974 return trychange.TryChange(
977 trychange_args, 975 trychange_args,
978 change=change, 976 change=change,
979 file_list=file_list,
980 swallow_exception=swallow_exception, 977 swallow_exception=swallow_exception,
981 prog='gcl try', 978 prog='gcl try',
982 extra_epilog='\n' 979 extra_epilog='\n'
983 'When called from gcl, use the format gcl try <change_name>.\n') 980 'When called from gcl, use the format gcl try <change_name>.\n')
984 981
985 982
986 @need_change_and_args 983 @need_change_and_args
987 @attrs(usage='[--no_presubmit]') 984 @attrs(usage='[--no_presubmit]')
988 def CMDcommit(change_info, args): 985 def CMDcommit(change_info, args):
989 """Commits the changelist to the repository.""" 986 """Commits the changelist to the repository."""
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
1480 raise 1477 raise
1481 print >> sys.stderr, ( 1478 print >> sys.stderr, (
1482 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' 1479 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
1483 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)) 1480 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
1484 return 1 1481 return 1
1485 1482
1486 1483
1487 if __name__ == "__main__": 1484 if __name__ == "__main__":
1488 fix_encoding.fix_encoding() 1485 fix_encoding.fix_encoding()
1489 sys.exit(main(sys.argv[1:])) 1486 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « no previous file | git_try.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698