Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Issue 8124002: Eliminate hacks needed to work around a limitation of base::Bind() (Closed)

Created:
9 years, 2 months ago by satorux1
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Eliminate hacks needed to work around a limitation of base::Bind() base::Bind() used to be unable to handle opaque type pointers, but the limitation was fixed in crrev.com/103627. BUG=crosbug.com/21166 TEST=build and run dbus_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103881

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -25 lines) Patch
M dbus/exported_object.h View 1 chunk +1 line, -1 line 0 comments Download
M dbus/exported_object.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M dbus/object_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/object_proxy.cc View 4 chunks +6 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
9 years, 2 months ago (2011-10-03 19:30:26 UTC) #1
awong
LGTM Thanks!
9 years, 2 months ago (2011-10-03 19:38:54 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8124002/1
9 years, 2 months ago (2011-10-03 22:04:37 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-04 13:47:23 UTC) #4
Change committed as 103881

Powered by Google App Engine
This is Rietveld 408576698