Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: dbus/exported_object.cc

Issue 8124002: Eliminate hacks needed to work around a limitation of base::Bind() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/exported_object.h ('k') | dbus/object_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/exported_object.cc
diff --git a/dbus/exported_object.cc b/dbus/exported_object.cc
index c4ebd3bf236dc4a0bacbf73eeb94998ff3cc6c2d..d20702407c4a3e282834a0149c2fedd73a381f01 100644
--- a/dbus/exported_object.cc
+++ b/dbus/exported_object.cc
@@ -105,13 +105,11 @@ void ExportedObject::SendSignal(Signal* signal) {
dbus_message_ref(signal_message);
const base::TimeTicks start_time = base::TimeTicks::Now();
- // Bind() won't compile if we pass signal_message. See the comment at
- // ObjectProxy::CallMethod() for details.
bus_->PostTaskToDBusThread(FROM_HERE,
base::Bind(&ExportedObject::SendSignalInternal,
this,
start_time,
- static_cast<void*>(signal_message)));
+ signal_message));
}
void ExportedObject::Unregister() {
@@ -153,9 +151,7 @@ void ExportedObject::OnExported(OnExportedCallback on_exported_callback,
}
void ExportedObject::SendSignalInternal(base::TimeTicks start_time,
- void* in_signal_message) {
- DBusMessage* signal_message =
- static_cast<DBusMessage*>(in_signal_message);
+ DBusMessage* signal_message) {
uint32 serial = 0;
bus_->Send(signal_message, &serial);
dbus_message_unref(signal_message);
« no previous file with comments | « dbus/exported_object.h ('k') | dbus/object_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698