Fix for disabling the remove Button when there are no selected items.

Fix for disabling the remove Button when there are no selected items.


BUG=73197
TEST=Remove an item from history and check that the remove button should be brought back to disabled state when no more items are selected for deletion.

[Patrick Dubroy, 2011-10-04 11:48:50]

Changes to history.js look good, but as with the other patch, please remove the
changes to history2.js, because they won't be necessary.

[naveenbobbili, 2011-10-04 11:58:38]

On 2011/10/04 11:48:50, dubroy wrote:
> Changes to history.js look good, but as with the other patch, please remove
the
> changes to history2.js, because they won't be necessary.

Ok I will upload this patch only for history.js and remove history2.js

[naveenbobbili, 2011-10-04 12:06:38]

Uploaded patch with changes only to history.js

[naveenbobbili, 2011-10-05 04:42:13]

On 2011/10/04 12:06:38, naveenbobbili wrote:
> Uploaded patch with changes only to history.js

Hi,
Can you please review this patch. I have removed history2 changes.

Regards,
Naveen

[NaveenBobbili (Motorola), 2011-10-10 04:41:04]

On 2011/10/05 04:42:13, naveenbobbili wrote:
> On 2011/10/04 12:06:38, naveenbobbili wrote:
> > Uploaded patch with changes only to history.js
> 
> Hi,
> Can you please review this patch. I have removed history2 changes.
> 
> Regards,
> Naveen

These changes are working fine and pending review. Please review this
changelist.

[NaveenBobbili (Motorola), 2011-10-13 08:28:16]

Please review this patch

[James Hawkins, 2011-10-15 20:35:43]

http://codereview.chromium.org/8116002/diff/4001/chrome/browser/resources/his...
File chrome/browser/resources/history.js (right):

http://codereview.chromium.org/8116002/diff/4001/chrome/browser/resources/his...
chrome/browser/resources/history.js:997: // Disable the remove button.
Remove redundant comment.

[NaveenBobbili (Motorola), 2011-10-17 06:35:59]

Thanks for posting your comments. I have uploaded a new patch set after
addressing your comments.

[James Hawkins, 2011-10-17 17:08:25]

On 2011/10/17 06:35:59, NaveenBobbili (Motorola) wrote:
> Thanks for posting your comments. I have uploaded a new patch set after
> addressing your comments.

Please go into each review comment and click the 'Done' button when you've made
the appropriate changes. There's only one comment in this CL, but when there's
more than one, it burdens the reviewer to have to see if each review issue was
fixed.

[Evan Stade, 2011-10-17 22:12:25]

CL description should be:

history: disable the 'remove' button after it's clicked.

[NaveenBobbili (Motorola), 2011-10-18 04:12:32]

http://codereview.chromium.org/8116002/diff/4001/chrome/browser/resources/his...
File chrome/browser/resources/history.js (right):

http://codereview.chromium.org/8116002/diff/4001/chrome/browser/resources/his...
chrome/browser/resources/history.js:997: // Disable the remove button.
On 2011/10/15 20:35:43, James Hawkins wrote:
> Remove redundant comment.

Done.

[NaveenBobbili (Motorola), 2011-10-18 04:27:27]

On 2011/10/17 22:12:25, Evan Stade wrote:
> CL description should be:
> 
> history: disable the 'remove' button after it's clicked.

Initially I was able to create reviews with my alias account
naveenbobbili@motorola.com. Due to internal motorola policy and new migrations
that took place I had to switch over and submit reviews using only my primary
account which is qghc36@motorola.com which is preventing me from editing this
issue. So I am creating a new review request after addressing all the review
comments with qghc36@motorola.com. I will have to switch over all my pending
review requests also. Sorry for the inconvienience. I have raised a new request
for the same issue at http://codereview.chromium.org/8341006.