Issue 8341006: History: Disable the 'remove' button after it's clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8341006: History: Disable the 'remove' button after it's clicked. (Closed)

Created:
9 years, 2 months ago by NaveenBobbili (Motorola)

Modified:
9 years, 2 months ago

Reviewers:
Patrick Dubroy, commit-bot: I haz the power, arv (Not doing code reviews), James Hawkins, Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

History: Disable the 'remove' button after it's clicked. BUG=73197 TEST=Remove an item from history and check that the remove button should be brought back to disabled state when no more items are selected for deletion. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106261

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/history.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

NaveenBobbili (Motorola)

This is a clone of http://codereview.chromium.org/8116002/ Sorry for the inconvenience.

9 years, 2 months ago (2011-10-18 04:27:03 UTC) #1

NaveenBobbili (Motorola)

On 2011/10/18 20:48:23, Evan Stade wrote: > lgtm Can you please commit this patch?

9 years, 2 months ago (2011-10-19 04:30:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qghc36@motorola.com/8341006/1

9 years, 2 months ago (2011-10-19 09:09:17 UTC) #4

Change committed as 106261

Expand Messages | Collapse Messages