Issue 8114025: fix _x11 exclusion rule for webkit_glue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8114025: fix _x11 exclusion rule for webkit_glue (Closed)

Created:
9 years, 2 months ago by Dirk Pranke

Modified:
9 years, 2 months ago

Reviewers:
tony, DaveMoore

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

fix _x11 exclusion rule for webkit_glue R=davemoore@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103845

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	webkit/glue/webkit_glue.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

lgtm. I think for webkit_glue that x11 and gtk should be mutually exclusive. If others ...

9 years, 2 months ago (2011-10-04 01:40:17 UTC) #2

tony

9 years, 2 months ago (2011-10-04 20:49:40 UTC) #3

On 2011/10/04 01:40:17, DaveMoore wrote:
> lgtm. I think for webkit_glue that x11 and gtk should be mutually exclusive.
If
> others think differently we can change the name of this file and explicitly
> include / exclude it.

I think we should rename this file.  We can call it _stub.cc or _aura.cc.  It's
confusing that x11 and gtk would be mutually exclusive (even more so to only
have it mutually exclusive in one part of the tree).

Expand Messages | Collapse Messages