Remove RenderProcessHost::is_extension_process

Remove RenderProcessHost::is_extension_process

Also move the --process=extension command line flag to --extension-process

BUG=89642
TEST=everything still works


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104173

[jochen (gone - plz use gerrit), 2011-10-04 13:17:34]

please review

John: content/

Aaron: rest

[jam, 2011-10-04 16:59:22]

thanks a lot for doing this cleanup, some minor comments

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (left):

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc#oldco...
chrome/app/chrome_main.cc:319: name_id = IDS_WORKER_APP_NAME;
do we want to use this in the "process_type == switches::kRendererProcess"
condition if --extension-process is passed?

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc#newco...
chrome/app/chrome_main.cc:33: #include "content/renderer/renderer_main.h"
this isn't needed anymore. we now actually don't even need to export this
function in that file, it was only done for here.

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:816: 
nit: extra line

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.h (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.h:124: // Can return an optional fd
for crash handling, otherwise returns -1. The
nit: this comment shouldn't be here, since we don't duplicate comments between
the interface and the implementations.

http://codereview.chromium.org/8113035/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_process_manager.h (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_process_manager.h:80: bool
IsExtensionProcess(int host_id);
to be consistent with everywhere else, please use "render_process_id"

http://codereview.chromium.org/8113035/diff/1/content/browser/content_browser...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/8113035/diff/1/content/browser/content_browser...
content/browser/content_browser_client.h:307: virtual int GetCrashSignalFD(const
CommandLine* command_line) = 0;
nit: const reference

[jochen (gone - plz use gerrit), 2011-10-04 18:50:19]

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (left):

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc#oldco...
chrome/app/chrome_main.cc:319: name_id = IDS_WORKER_APP_NAME;
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> do we want to use this in the "process_type == switches::kRendererProcess"
> condition if --extension-process is passed?

Done.

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

http://codereview.chromium.org/8113035/diff/1/chrome/app/chrome_main.cc#newco...
chrome/app/chrome_main.cc:33: #include "content/renderer/renderer_main.h"
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> this isn't needed anymore. we now actually don't even need to export this
> function in that file, it was only done for here.

Done.

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:816: 
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> nit: extra line

Done.

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.h (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.h:124: // Can return an optional fd
for crash handling, otherwise returns -1. The
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> nit: this comment shouldn't be here, since we don't duplicate comments between
> the interface and the implementations.

Done.

http://codereview.chromium.org/8113035/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_process_manager.h (right):

http://codereview.chromium.org/8113035/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_process_manager.h:80: bool
IsExtensionProcess(int host_id);
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> to be consistent with everywhere else, please use "render_process_id"

Done.

http://codereview.chromium.org/8113035/diff/1/content/browser/content_browser...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/8113035/diff/1/content/browser/content_browser...
content/browser/content_browser_client.h:307: virtual int GetCrashSignalFD(const
CommandLine* command_line) = 0;
On 2011/10/04 16:59:22, John Abd-El-Malek wrote:
> nit: const reference

Done.

[jam, 2011-10-04 20:19:34]

lgtm

http://codereview.chromium.org/8113035/diff/6001/content/renderer/renderer_ma...
File content/renderer/renderer_main.h (right):

http://codereview.chromium.org/8113035/diff/6001/content/renderer/renderer_ma...
content/renderer/renderer_main.h:12: int RendererMain(const MainFunctionParams&
parameters);
nit: this file isn't needed anymore, we can forward declare RendererMain like we
do the other functions in
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/app/content_m...
and delete this file

[jochen (gone - plz use gerrit), 2011-10-04 20:25:59]

http://codereview.chromium.org/8113035/diff/6001/content/renderer/renderer_ma...
File content/renderer/renderer_main.h (right):

http://codereview.chromium.org/8113035/diff/6001/content/renderer/renderer_ma...
content/renderer/renderer_main.h:12: int RendererMain(const MainFunctionParams&
parameters);
On 2011/10/04 20:19:35, John Abd-El-Malek wrote:
> nit: this file isn't needed anymore, we can forward declare RendererMain like
we
> do the other functions in
>
http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/content/app/content_m...
> and delete this file

Done.

[Mihai Parparita -not on Chrome, 2011-10-04 22:24:13]

http://codereview.chromium.org/8113035/diff/4003/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/8113035/diff/4003/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_dispatcher.cc:46:
CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess);
This line is now a no-op, since you removed the || from the previous line.

[jochen (gone - plz use gerrit), 2011-10-05 07:43:45]

http://codereview.chromium.org/8113035/diff/4003/chrome/renderer/extensions/e...
File chrome/renderer/extensions/extension_dispatcher.cc (right):

http://codereview.chromium.org/8113035/diff/4003/chrome/renderer/extensions/e...
chrome/renderer/extensions/extension_dispatcher.cc:46:
CommandLine::ForCurrentProcess()->HasSwitch(switches::kSingleProcess);
On 2011/10/04 22:24:14, Mihai Parparita wrote:
> This line is now a no-op, since you removed the || from the previous line.

Done.

[Aaron Boodman, 2011-10-05 15:35:03]

lgtm otherwise

http://codereview.chromium.org/8113035/diff/6005/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/8113035/diff/6005/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.cc:98: // These are duplicated from
ExtensionProcessManager :(.
I didn't see this before, but as long as you're editing this file, can you add
"so that we can have the information on the IO thread" before the frown.

[jochen (gone - plz use gerrit), 2011-10-05 18:55:42]

http://codereview.chromium.org/8113035/diff/6005/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_info_map.cc (right):

http://codereview.chromium.org/8113035/diff/6005/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_info_map.cc:98: // These are duplicated from
ExtensionProcessManager :(.
On 2011/10/05 15:35:04, Aaron Boodman wrote:
> I didn't see this before, but as long as you're editing this file, can you add
> "so that we can have the information on the IO thread" before the frown.

Done.

[commit-bot: I haz the power, 2011-10-05 18:56:01]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8113035/10001

[commit-bot: I haz the power, 2011-10-05 21:16:57]

Change committed as 104173