Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: content/browser/renderer_host/browser_render_process_host.cc

Issue 8113035: Remove RenderProcessHost::is_extension_process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/mock_content_browser_client.cc ('k') | content/browser/renderer_host/render_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/browser_render_process_host.cc
diff --git a/content/browser/renderer_host/browser_render_process_host.cc b/content/browser/renderer_host/browser_render_process_host.cc
index 2228cd89b197207586ca45e1c4761a626dfee623..dd0d6a077d000a0fe3048ab06c2a740888b4bbe5 100644
--- a/content/browser/renderer_host/browser_render_process_host.cc
+++ b/content/browser/renderer_host/browser_render_process_host.cc
@@ -490,11 +490,8 @@ int BrowserRenderProcessHost::VisibleWidgetCount() const {
void BrowserRenderProcessHost::AppendRendererCommandLine(
CommandLine* command_line) const {
// Pass the process type first, so it shows first in process listings.
- // Extensions use a special pseudo-process type to make them distinguishable,
- // even though they're just renderers.
command_line->AppendSwitchASCII(switches::kProcessType,
- is_extension_process_ ? switches::kExtensionProcess :
- switches::kRendererProcess);
+ switches::kRendererProcess);
if (accessibility_enabled_)
command_line->AppendSwitch(switches::kEnableAccessibility);
@@ -864,24 +861,7 @@ void BrowserRenderProcessHost::ProcessDied(
// calls to a renderer. If we don't have a valid channel here it means we
// already handled the error.
- if (status == base::TERMINATION_STATUS_PROCESS_CRASHED ||
- status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashes",
- is_extension_process_ ? 2 : 1);
- if (was_alive) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildCrashesWasAlive",
- is_extension_process_ ? 2 : 1);
- }
- } else if (status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKills",
- is_extension_process_ ? 2 : 1);
- if (was_alive) {
- UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.ChildKillsWasAlive",
- is_extension_process_ ? 2 : 1);
- }
- }
-
- RendererClosedDetails details(status, exit_code, is_extension_process_);
+ RendererClosedDetails details(status, exit_code, was_alive);
NotificationService::current()->Notify(
content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
Source<RenderProcessHost>(this),
« no previous file with comments | « content/browser/mock_content_browser_client.cc ('k') | content/browser/renderer_host/render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698