Issue 8103: - Fixed performance regression caused by ComputeContextSlotReceiver....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8103: - Fixed performance regression caused by ComputeContextSlotReceiver.... (Closed)

Created:
12 years, 2 months ago by bak

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Fixed performance regression caused by ComputeContextSlotReceiver. - Eliminated a few write barriers. Committed: http://code.google.com/p/v8/source/detail?r=573

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -60 lines)			Patch
M	src/heap.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/heap.cc	View		3 chunks	+4 lines, -13 lines	0 comments	Download
M	src/objects.h	View		4 chunks	+6 lines, -5 lines	1 comment	Download
M	src/objects.cc	View		4 chunks	+6 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View		5 chunks	+11 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View	1	6 chunks	+41 lines, -23 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

12 years, 2 months ago (2008-10-23 14:51:33 UTC) #2

LGTM.

http://codereview.chromium.org/8103/diff/201/205
File src/objects.h (right):

http://codereview.chromium.org/8103/diff/201/205#newcode2462
Line 2462: static const int kUnusedXX = 0;  // To be used for marking recently
used maps.
Did you mean to change this?

http://codereview.chromium.org/8103/diff/201/204
File src/runtime.cc (right):

http://codereview.chromium.org/8103/diff/201/204#newcode3385
Line 3385: // Contexts and Globals are most common.
I would change Globals to 'global objects', but that's just silly me.

http://codereview.chromium.org/8103/diff/201/204#newcode3386
Line 3386: HeapObject* object = HeapObject::cast(holder);
You should be able to get rid of the 'object' variable. It isn't really that
useful. Sorry for leaving that crud in there in the first place.

Expand Messages | Collapse Messages