Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: src/objects-inl.h

Issue 8103: - Fixed performance regression caused by ComputeContextSlotReceiver.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
===================================================================
--- src/objects-inl.h (revision 572)
+++ src/objects-inl.h (working copy)
@@ -510,7 +510,7 @@
#define WRITE_BARRIER(object, offset) \
Heap::RecordWrite(object->address(), offset);
-// CONITIONAL_WRITE_BARRIER must be issued after the actual
+// CONDITIONAL_WRITE_BARRIER must be issued after the actual
// write due to the assert validating the written value.
#define CONDITIONAL_WRITE_BARRIER(object, offset, mode) \
if (mode == UPDATE_WRITE_BARRIER) { \
@@ -1534,9 +1534,9 @@
}
-void ConsString::set_first(Object* value) {
+void ConsString::set_first(Object* value, WriteBarrierMode mode) {
WRITE_FIELD(this, kFirstOffset, value);
- WRITE_BARRIER(this, kFirstOffset);
+ CONDITIONAL_WRITE_BARRIER(this, kFirstOffset, mode);
}
@@ -1545,9 +1545,9 @@
}
-void ConsString::set_second(Object* value) {
+void ConsString::set_second(Object* value, WriteBarrierMode mode) {
WRITE_FIELD(this, kSecondOffset, value);
- WRITE_BARRIER(this, kSecondOffset);
+ CONDITIONAL_WRITE_BARRIER(this, kSecondOffset, mode);
}
@@ -2071,6 +2071,11 @@
}
+int JSFunction::NumberOfLiterals() {
+ return literals()->length();
+}
+
+
Object* JSBuiltinsObject::javascript_builtin(Builtins::JavaScript id) {
ASSERT(0 <= id && id < kJSBuiltinsCount);
return READ_FIELD(this, kJSBuiltinsOffset + (id * kPointerSize));
@@ -2351,7 +2356,7 @@
void JSArray::SetContent(FixedArray* storage) {
- set_length(Smi::FromInt(storage->length()));
+ set_length(Smi::FromInt(storage->length()), SKIP_WRITE_BARRIER);
set_elements(storage);
}

Powered by Google App Engine
This is Rietveld 408576698