Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 8102: Cleanup of http://codereview.chromium.org/8101.... (Closed)

Created:
12 years, 2 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup of http://codereview.chromium.org/8101. Changed the catcher_ field to a boolean value and renamed it. Modified the propagation of the external caught exception to also clear the current TryCatch if there is no exception as it might hold an exception which has been bypassed by code in a finally block. Minor formatting changes to a test. Committed: http://code.google.com/p/v8/source/detail?r=576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -59 lines) Patch
M src/execution.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/top.h View 2 chunks +17 lines, -5 lines 0 comments Download
M src/top.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A + test/mjsunit/api-call-after-bypassed-exception.js View 1 chunk +3 lines, -5 lines 0 comments Download
D test/mjsunit/api-call-after-overridden-exception.js View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
12 years, 2 months ago (2008-10-23 14:39:06 UTC) #1
Kasper Lund
Looks better to me. It still seems waaaay too complicated, but it's certainly better.
12 years, 2 months ago (2008-10-23 14:43:26 UTC) #2
Christian Plesner Hansen
12 years, 2 months ago (2008-10-23 15:37:36 UTC) #3
Lgtm

Powered by Google App Engine
This is Rietveld 408576698