Posponed the setting of "external_caught_exception" to when leaving JavaScrip...

Posponed the setting of "external_caught_exception" to when leaving JavaScript
execution. This is achieved by storing a pointer to the C++ TryCatch when the
exception is thrown and checking that this is the handler active when leaving
JavaScript.

Committed: http://code.google.com/p/v8/source/detail?r=570

[Kasper Lund, 2008-10-23 12:52:43]

LGTM. Please explain catcher_ though...

http://codereview.chromium.org/8101/diff/1/3
File src/top.cc (right):

http://codereview.chromium.org/8101/diff/1/3#newcode610
Line 610: // Set the exception beeing re-thrown.
beeing sb. being

http://codereview.chromium.org/8101/diff/1/4
File src/top.h (right):

http://codereview.chromium.org/8101/diff/1/4#newcode56
Line 56: v8::TryCatch* catcher_;
Maybe you should explain what the difference between try_catch_handler_ and
catcher_ is?

http://codereview.chromium.org/8101/diff/1/4#newcode150
Line 150: (Top::thread_local_.try_catch_handler_ ==
Top::thread_local_.catcher_);
Why do you use Top:: here? You're inside Top, right?

http://codereview.chromium.org/8101/diff/1/2
File test/mjsunit/api-call-after-overridden-exception.js (right):

http://codereview.chromium.org/8101/diff/1/2#newcode31
Line 31: {
Move { to previous line.

[Christian Plesner Hansen, 2008-10-23 13:09:38]

Lgtm, with comments.

http://codereview.chromium.org/8101/diff/1/4
File src/top.h (right):

http://codereview.chromium.org/8101/diff/1/4#newcode56
Line 56: v8::TryCatch* catcher_;
What about a more descriptive name for this one?  active_external_handler_
maybe?

http://codereview.chromium.org/8101/diff/1/4#newcode150
Line 150: (Top::thread_local_.try_catch_handler_ ==
Top::thread_local_.catcher_);
If the catcher is set won't it always be the top exception handler?