Posponed the setting of "external_caught_exception" to when leaving JavaScrip...

src/top.h

Index: src/top.h
===================================================================
--- src/top.h	(revision 567)
+++ src/top.h	(working copy)
@@ -53,6 +53,7 @@
   bool external_caught_exception_;
   v8::TryCatch* try_catch_handler_;
   SaveContext* save_context_;
+  v8::TryCatch* catcher_;

[Kasper Lund, 2008/10/23 12:52:43]

Maybe you should explain what the difference between try_catch_handler_ and
catcher_ is?

[Christian Plesner Hansen, 2008/10/23 13:09:38]

What about a more descriptive name for this one?  active_external_handler_
maybe?

 
   // Stack.
   Address c_entry_fp_;  // the frame pointer of the top c entry frame
@@ -143,6 +144,12 @@
     thread_local_.scheduled_exception_ = Heap::the_hole_value();
   }
 
+  static void setup_external_caught() {
+    thread_local_.external_caught_exception_ =
+        (thread_local_.catcher_ != NULL) &&
+        (Top::thread_local_.try_catch_handler_ == Top::thread_local_.catcher_);

[Kasper Lund, 2008/10/23 12:52:43]

Why do you use Top:: here? You're inside Top, right?

[Christian Plesner Hansen, 2008/10/23 13:09:38]

If the catcher is set won't it always be the top exception handler?

+  }
+
   // Tells whether the current context has experienced an out of memory
   // exception.
   static bool is_out_of_memory();