Issue 8098017: Make content_shell handle renderers going away. I've made TabContents call TabContentsView::OnTab...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8098017: Make content_shell handle renderers going away. I've made TabContents call TabContentsView::OnTab... (Closed)

Created:
9 years, 2 months ago by jam

Modified:
9 years, 2 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Avi (use Gerrit), dpranke+watch-content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make content_shell handle renderers going away. I've made TabContents call TabContentsView::OnTabCrashed, instead of before where the embedder called that function. BUG=90445 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103655

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -13 lines)			Patch
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view_win.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages