Make content_shell handle renderers going away. I've made TabContents call TabContentsView::OnTab...

chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tab_contents/tab_contents_view_views.h"
 
 #include <vector>
 
 #include "base/time.h"
+#include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/ui/constrained_window_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/ui/views/sad_tab_view.h"
 #include "chrome/browser/ui/views/tab_contents/native_tab_contents_view.h"
 #include "chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h"
 #include "content/browser/renderer_host/render_process_host.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/renderer_host/render_view_host_factory.h"
 #include "content/browser/renderer_host/render_widget_host_view.h"
 #include "content/browser/tab_contents/interstitial_page.h"
@@ skipping 100 matching lines @@
                                          const gfx::Point& image_offset) {
   native_tab_contents_view_->StartDragging(drop_data, ops, image, image_offset);
 }
 
 void TabContentsViewViews::SetPageTitle(const string16& title) {
   native_tab_contents_view_->SetPageTitle(title);
 }
 
 void TabContentsViewViews::OnTabCrashed(base::TerminationStatus status,
                                         int /* error_code */) {
+  // Only show the sad tab if we're not in browser shutdown, so that TabContents
+  // objects that are not in a browser (e.g., HTML dialogs) and thus are
+  // visible do not flash a sad tab page.
+  if (browser_shutdown::GetShutdownType() != browser_shutdown::NOT_VALID)
+    return;
+
   // Force an invalidation to render sad tab.
   // Note that it's possible to get this message after the window was destroyed.
   if (GetNativeView()) {
     SadTabView::Kind kind =
         status == base::TERMINATION_STATUS_PROCESS_WAS_KILLED ?
         SadTabView::KILLED : SadTabView::CRASHED;
     sad_tab_ = new SadTabView(tab_contents_, kind);
     SetContentsView(sad_tab_);
     sad_tab_->SchedulePaint();
   }
@@ skipping 297 matching lines @@
 }
 
 void TabContentsViewViews::OnNativeWidgetVisibilityChanged(bool visible) {
   views::Widget::OnNativeWidgetVisibilityChanged(visible);
   if (visible) {
     tab_contents_->ShowContents();
   } else {
     tab_contents_->HideContents();
   }
 }