Issue 8095016: Additional build fixes for aura

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8095016: Additional build fixes for aura (Closed)

Created:
9 years, 2 months ago by DaveMoore

Modified:
9 years, 2 months ago

Reviewers:
tony, oshima

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Additional build fixes for aura - Fix webcursor - Fix compile regression for set_visibility -> show() / hide() - Fix compile regression for ChromeBrowserMainParts BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103713

Patch Set 1 #

Patch Set 2 : Add missing file #

Total comments: 4

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -18 lines)			Patch
M	chrome/browser/chrome_browser_main_aura.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/platform_util_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/aura/aura_init.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webcursor.h	View		4 chunks	+8 lines, -5 lines	3 comments	Download
M	webkit/glue/webcursor_gtk.cc	View		2 chunks	+0 lines, -10 lines	0 comments	Download
A	webkit/glue/webcursor_x11.cc	View	1	1 chunk	+32 lines, -0 lines	1 comment	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor_x11.cc File webkit/glue/webcursor_x11.cc (right): http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor_x11.cc#newcode14 webkit/glue/webcursor_x11.cc:14: } NOTIMPLEMENTED() so that we don't miss it.

9 years, 2 months ago (2011-09-30 22:47:46 UTC) #2

tony

9 years, 2 months ago (2011-10-04 20:50:33 UTC) #3

See also comment on http://codereview.chromium.org/8114025/ .

Would have been nice to have gotten OWNERS approval for this change. :)

http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor.h
File webkit/glue/webcursor.h (right):

http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor.h#newcode22
webkit/glue/webcursor.h:22: // TODO(davemoore) define X11 specific cursor
implementation.
Nit: These empty #if defined(USES_X11) blocks are weird.

http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor.h#newcode95
webkit/glue/webcursor.h:95: #elif defined(USES_X11)
ditto

http://codereview.chromium.org/8095016/diff/14/webkit/glue/webcursor.h#newcod...
webkit/glue/webcursor.h:160: 
ditto

Expand Messages | Collapse Messages