Defer loading of audio/video tags while prerendering.

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 88d41cf849ca5ab2506faad688bf19bb31e24276..8294d64b48cf5bf727c2508fea808b35e98be5cd 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -47,6 +47,7 @@
 #include "chrome/renderer/page_load_histograms.h"
 #include "chrome/renderer/plugin_uma.h"
 #include "chrome/renderer/prerender/prerender_helper.h"
+#include "chrome/renderer/prerender/prerender_webmediaplayer.h"
 #include "chrome/renderer/print_web_view_helper.h"
 #include "chrome/renderer/renderer_histogram_snapshots.h"
 #include "chrome/renderer/safe_browsing/malware_dom_details.h"
@@ -278,6 +279,24 @@ bool ChromeContentRendererClient::OverrideCreatePlugin(
   return true;
 }
 
+bool ChromeContentRendererClient::ShouldOverrideCreateWebMediaPlayer(
+    RenderView* view) {
+  return prerender::PrerenderHelper::IsPrerendering(view);
+}
+
+void ChromeContentRendererClient::OverrideCreateWebMediaPlayer(
+    RenderView* render_view,
+    WebKit::WebMediaPlayerClient* client,
+    media::FilterCollection* collection,
+    media::MessageLoopFactory* message_loop_factory,
+    webkit_glue::MediaStreamClient* media_stream_client,
+    media::MediaLog* media_log,
+    webkit_glue::WebMediaPlayerImpl** player) {
+  DCHECK(!prerender::PrerenderHelper::IsPrerendering(render_view));

[scherkus (not reviewing), 2011/10/03 18:19:45]

call ShouldOverrideXXX() method instead?

also, what do you think about combining the two methods similar to
OverrideCreatePlugin() -- if it returns false then player == NULL

[Shishir, 2011/10/04 23:02:39]

Changed to ShouldOverrideCreateWebMediaPlayer().

I had combined them initially, but felt that it was confusing because its not
clear what happens to the ownership of the input pointers if the player is NULL.
What do you think?

On 2011/10/03 18:19:45, scherkus wrote:

[scherkus (not reviewing), 2011/10/05 20:21:58]

I'm pretty indifferent -- if you feel the current setup is more clear then go
with that :)

+  *player = new prerender::PrerenderWebMediaPlayer(render_view, client,
+      collection, message_loop_factory, media_stream_client, media_log);
+}
+
 WebPlugin* ChromeContentRendererClient::CreatePlugin(
       RenderView* render_view,
       WebFrame* frame,