Defer loading of audio/video tags while prerendering.

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/message_loop.h"
@@ skipping 29 matching lines @@
 #include "chrome/renderer/extensions/extension_resource_request_policy.h"
 #include "chrome/renderer/extensions/renderer_extension_bindings.h"
 #include "chrome/renderer/external_extension.h"
 #include "chrome/renderer/loadtimes_extension_bindings.h"
 #include "chrome/renderer/localized_error.h"
 #include "chrome/renderer/net/renderer_net_predictor.h"
 #include "chrome/renderer/page_click_tracker.h"
 #include "chrome/renderer/page_load_histograms.h"
 #include "chrome/renderer/plugin_uma.h"
 #include "chrome/renderer/prerender/prerender_helper.h"
+#include "chrome/renderer/prerender/prerender_webmediaplayer.h"
 #include "chrome/renderer/print_web_view_helper.h"
 #include "chrome/renderer/renderer_histogram_snapshots.h"
 #include "chrome/renderer/safe_browsing/malware_dom_details.h"
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
 #include "chrome/renderer/search_extension.h"
 #include "chrome/renderer/searchbox.h"
 #include "chrome/renderer/searchbox_extension.h"
 #include "chrome/renderer/spellchecker/spellcheck.h"
 #include "chrome/renderer/spellchecker/spellcheck_provider.h"
 #include "chrome/renderer/translate_helper.h"
@@ skipping 211 matching lines @@
       const WebPluginParams& params,
       WebKit::WebPlugin** plugin) {
   bool is_default_plugin;
   *plugin = CreatePlugin(render_view, frame, params, &is_default_plugin);
   if (!*plugin || is_default_plugin)
     MissingPluginReporter::GetInstance()->ReportPluginMissing(
         params.mimeType.utf8(), params.url);
   return true;
 }
 
+bool ChromeContentRendererClient::ShouldOverrideCreateWebMediaPlayer(
+    RenderView* view) {
+  return prerender::PrerenderHelper::IsPrerendering(view);
+}
+
+void ChromeContentRendererClient::OverrideCreateWebMediaPlayer(
+    RenderView* render_view,
+    WebKit::WebMediaPlayerClient* client,
+    media::FilterCollection* collection,
+    media::MessageLoopFactory* message_loop_factory,
+    webkit_glue::MediaStreamClient* media_stream_client,
+    media::MediaLog* media_log,
+    webkit_glue::WebMediaPlayerImpl** player) {
+  DCHECK(!prerender::PrerenderHelper::IsPrerendering(render_view));

[scherkus (not reviewing), 2011/10/03 18:19:45]

call ShouldOverrideXXX() method instead?

also, what do you think about combining the two methods similar to
OverrideCreatePlugin() -- if it returns false then player == NULL

[Shishir, 2011/10/04 23:02:39]

Changed to ShouldOverrideCreateWebMediaPlayer().

I had combined them initially, but felt that it was confusing because its not
clear what happens to the ownership of the input pointers if the player is NULL.
What do you think?

On 2011/10/03 18:19:45, scherkus wrote:

[scherkus (not reviewing), 2011/10/05 20:21:58]

I'm pretty indifferent -- if you feel the current setup is more clear then go
with that :)

+  *player = new prerender::PrerenderWebMediaPlayer(render_view, client,
+      collection, message_loop_factory, media_stream_client, media_log);
+}
+
 WebPlugin* ChromeContentRendererClient::CreatePlugin(
       RenderView* render_view,
       WebFrame* frame,
       const WebPluginParams& original_params,
       bool* is_default_plugin) {
   *is_default_plugin = false;
   CommandLine* cmd = CommandLine::ForCurrentProcess();
   webkit::WebPluginInfo info;
   GURL url(original_params.url);
   std::string orig_mime_type = original_params.mimeType.utf8();
@@ skipping 478 matching lines @@
   if (spellcheck_.get())
     thread->RemoveObserver(spellcheck_.get());
   SpellCheck* new_spellcheck = new SpellCheck();
   if (spellcheck_provider_)
     spellcheck_provider_->SetSpellCheck(new_spellcheck);
   spellcheck_.reset(new_spellcheck);
   thread->AddObserver(new_spellcheck);
 }
 
 }  // namespace chrome