chrome/browser/chromeos/login/signed_settings.h - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signed_settings.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments and fixed an issue with user whitelist checks. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/login_performer.cc ('K') | « chrome/browser/chromeos/login/mock_signed_settings_helper.h ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | chrome/browser/chromeos/user_cros_settings_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signed_settings.h

diff --git a/chrome/browser/chromeos/login/signed_settings.h b/chrome/browser/chromeos/login/signed_settings.h

index a423aaed70ccd5234a6ca2e29bce56d7e5f9abc2..0b6623907aa616ee9abc83aca5d7c6ed064a57f2 100644

--- a/chrome/browser/chromeos/login/signed_settings.h

+++ b/chrome/browser/chromeos/login/signed_settings.h

@@ -10,6 +10,7 @@

#include <vector>

#include "base/memory/ref_counted.h"

+#include "base/values.h"

#include "chrome/browser/chromeos/login/owner_manager.h"

// There are two categories of operations that can be performed on the

@@ -74,12 +75,12 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,

// one type can be in flight at a time.

static SignedSettings* CreateStorePropertyOp(

const std::string& name,

- const std::string& value,

+ const base::Value& value,

SignedSettings::Delegate<bool>* d);

static SignedSettings* CreateRetrievePropertyOp(

const std::string& name,

- SignedSettings::Delegate<std::string>* d);

+ SignedSettings::Delegate<const base::Value*>* d);

// These are both "policy" operations, and only one instance of

// one type can be in flight at a time.