PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/login/login_performer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_performer.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 263 matching lines @@
     }
   }
 
   bool allow_new_user = false;
   cros_settings->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
   if (ScreenLocker::default_screen_locker() || allow_new_user) {
     // Starts authentication if guest login is allowed or online auth pending.
     StartLoginCompletion();
   } else {
     // Otherwise, do whitelist check first.
-    const base::ListValue *user_list;
-    base::StringValue username_value(username);
-    if (cros_settings->GetList(kAccountsPrefUsers, &user_list) &&
-        user_list->Find(username_value) != user_list->end()) {
+    if (cros_settings->FindEmailInList(kAccountsPrefUsers, username)) {

[Mattias Nissler (ping if slow), 2011/10/28 14:44:07]

why has this worked before if we didn't check *@domain.com?

[pastarmovj, 2011/11/18 13:18:42]

Because there is some code that whitelists existing users when the checkbox to
restrict users is clicked. However I haven't seen code that does this for cloud
policy so we might have had some issues there with that. Moreover this code will
not get run for new users logging for the first time so no issues there too.

       StartLoginCompletion();
     } else {
       if (delegate_)
         delegate_->WhiteListCheckFailed(username);
       else
         NOTREACHED();
     }
   }
 }
 
@@ skipping 21 matching lines @@
       return;
     }
   }
 
   bool allow_new_user = false;
   cros_settings->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
   if (ScreenLocker::default_screen_locker() || allow_new_user) {
     // Starts authentication if guest login is allowed or online auth pending.
     StartAuthentication();
   } else {
-    const base::ListValue *user_list;
-    base::StringValue username_value(username);
-    if (cros_settings->GetList(kAccountsPrefUsers, &user_list) &&
-        user_list->Find(username_value) != user_list->end()) {
+    if (cros_settings->FindEmailInList(kAccountsPrefUsers, username)) {
       StartAuthentication();
     } else {
       if (delegate_)
         delegate_->WhiteListCheckFailed(username);
       else
         NOTREACHED();
     }
   }
 }
 
@@ skipping 213 matching lines @@
                    profile,
                    username_,
                    password_,
                    captcha_token_,
                    captcha_));
   }
   password_.clear();
 }
 
 }  // namespace chromeos